Storybook: Fix E2E subpath exports and add CI build smoke test#77034
Merged
Storybook: Fix E2E subpath exports and add CI build smoke test#77034
Conversation
mirka
added
[Type] Build Tooling
|
Size Change: 0 B Total Size: 7.74 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 4825038. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23951694047
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
|
I wonder whether the changes in this commit are still relevant gutenberg/test/storybook-playwright/tsconfig.json Lines 6 to 14 in d81fcdb |
Member
Author
I checked this and those overrides are still needed. So I don’t think this PR makes that workaround obsolete. |
aduth
approved these changes
Apr 6, 2026
Member
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
I confirmed npm run storybook:e2e:dev is failing on trunk and fixed on this branch. The export changes make sense based on what we're currently importing. I suppose another option could have been to add the file extensions at the import sites to let them traverse into the package directory? (though I'm generally in favor of explicit exports, now we have an API to maintain, albeit internal)
The CI integration raises some interesting questions though. I think it makes sense to want to make sure this flow is functional, though it may add to the overall build time. The bigger question for me is why we continue to maintain this at all if we don't have any broader assurances that the tests are actually exercised during CI. I'll admit to barely being aware of what exists in test/storybook-playwright and the current shape of those tests (whether they pass, how they're maintained over time, etc.). How do we ideally want this to work?
Member
Author
They are a place for specialized vizreg testing which is only necessitated for certain kinds of changes to specific components. It's too much to run on every change to those specific component files, much less on every PR. So that's why we just keep it available to maintainers on an as-needed basis. It could be possible to organize these in a different way, for example integrate them into the existing Storybook setup or the wp-components package, but I think there are trade-offs regarding discoverability and isolation of concerns. So I'm not feeling much urgency to change it up, unless we run into other factors like on-going maintainability. |
adamsilverstein
pushed a commit
that referenced
this pull request
Apr 7, 2026
* Storybook: fix E2E package exports and add CI build smoke test * Storybook: drop extra Node heap for E2E build Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: aduth <aduth@git.wordpress.org> Co-authored-by: manzoorwanijk <manzoorwanijk@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adds
exportson@wordpress/storybookfor./mainand./previewso Node can resolve the paths used by the Playwright Storybook app (storybook:e2e:dev/test/storybook-playwright).Also adds a static build for that app (
storybook:e2e:build) and runs it in the existing Storybook CI workflow right after the main Storybook build.Why?
Storybook 10 evaluates
main.tswith a TS loader, but bare imports like@wordpress/storybook/mainstill go through normal package resolution. Withoutexports, Node looks for a file namedmainwith no extension and fails (ERR_MODULE_NOT_FOUND). The CI step catches similar breakages before they land.Testing Instructions
npm run storybook:e2e:devand confirm Storybook starts.The CI test will test the
npm run storybook:e2e:buildcase.Use of AI Tools
Cursor was used to trace the Storybook/Node resolution error, add the
exportsand CI wiring, and to draft this description.