DataForm: Show tooltip in edit button in panel layout#77024
Open
ntsekouras wants to merge 1 commit intotrunkfrom
Open
DataForm: Show tooltip in edit button in panel layout#77024ntsekouras wants to merge 1 commit intotrunkfrom
panel layout#77024ntsekouras wants to merge 1 commit intotrunkfrom
Conversation
ntsekouras
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -22 B (0%) Total Size: 7.74 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 01249a0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23943233456
|
Contributor
|
The tooltip helps clarification, but the appearance is still strange. It'd be good to find a more complete solution. A couple of ideas:
|
Contributor
Author
|
@jameskoster I've expanded about the
|
jameskoster
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Extracted from #76934
There are cases when we use the
panelDataForm layout with a field that its value is not required and we don't want to show a label. If it's empty, we end up with just theedit(pencil) icon button with no context about which this field is.Adding the tooltip I think is the minimum.
This might be useful for
excerptanddescriptionfields, if we end up not showing any labels.Testing Instructions
npm run storybook:dev) -?path=/story/dataviews-dataform--layout-panellabelPosition:noneand edit the title to empty it.Screenshots or screencast