Components: Use --wpds-cursor-control for interactive controls (Sass only)#76786
Components: Use --wpds-cursor-control for interactive controls (Sass only)#76786
--wpds-cursor-control for interactive controls (Sass only)#76786Conversation
|
Size Change: +87 B (0%) Total Size: 7.74 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in c8cb68a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24249553420
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
9c35c81 to
c8cb68a
Compare
aduth
left a comment
There was a problem hiding this comment.
LGTM 👍 Hope you don't mind, I rebased to resolve conflicts in review. Tested in Storybook, both toggling between Theme Cursor Control options & verifying fallback styles in inspector.
What?
Part of #76221
Replaces hardcoded
cursor: pointerdeclarations in stylesheet-based@wordpress/componentscontrols withcursor: var(--wpds-cursor-control).This PR only updates the regular Sass stylesheets. Emotion-based styles will be handled separately.
Why?
The
--wpds-cursor-controltoken exists so control cursor behavior can be configured centrally.@wordpress/componentshad hardcodedpointercursors in its Sass stylesheets, which prevented those controls from following the shared design system setting.How?
Updated hardcoded
cursor: pointerdeclarations tocursor: var(--wpds-cursor-control)in the relevant Sass styles for:AlignmentMatrixControlButtonCalendarCheckboxControlCircularOptionPickerColorPaletteDropdownMenuFormToggleFormTokenFieldRadioControlSnackbarTabPanelToggleControlThe remaining Emotion-based usages need a separate follow-up.
Testing Instructions
npm run storybook:dev.Button,CheckboxControl,DropdownMenu,RadioControl,ToggleControl, andTabPanel.Use of AI Tools
Authored with Cursor (Claude).