Boot: Fix black area below content when sidebar is taller than page content#76764
Conversation
…ontent The `.boot-layout--single-page` selector (specificity 0,2,0) was setting `height: calc(100vh - $admin-bar-height-big)` for all viewports, but the desktop `@include mixins.break-medium` reset (specificity 0,1,0) could not override it. This locked content height to the viewport on desktop in single-page mode, creating a black gap below when scrolling. Fix: - Add matching-specificity `.boot-layout--single-page &` overrides inside the `break-medium` blocks for stage/inspector and canvas to reset `top` and `height` to `auto` on desktop. - Change `.boot-layout` from `height: 100%` to `min-height: 100%` so the layout container can grow when content exceeds the viewport. Closes WordPress#76478
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @sandipmaurya2611@gmail.com. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @sandipmaurya2611! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
|
Thanks for working on this! |
`top` has no effect when `position: static` is applied in break-medium blocks. `height: auto` is retained to override the mobile rule (`.boot-layout--single-page`, specificity 0,2,0) which sets `height: calc(100vh - $admin-bar-height-big)`. Without this override, the black gap persists on desktop.
shimotmk
left a comment
There was a problem hiding this comment.
Thanks for the help! I think that's good.
|
@props-bot refresh |
… page c… (#76764) * Boot: Fix black area below content when sidebar is taller than page content The `.boot-layout--single-page` selector (specificity 0,2,0) was setting `height: calc(100vh - $admin-bar-height-big)` for all viewports, but the desktop `@include mixins.break-medium` reset (specificity 0,1,0) could not override it. This locked content height to the viewport on desktop in single-page mode, creating a black gap below when scrolling. Fix: - Add matching-specificity `.boot-layout--single-page &` overrides inside the `break-medium` blocks for stage/inspector and canvas to reset `top` and `height` to `auto` on desktop. - Change `.boot-layout` from `height: 100%` to `min-height: 100%` so the layout container can grow when content exceeds the viewport. Closes #76478 * fix: remove redundant `top: auto` from single-page desktop styles `top` has no effect when `position: static` is applied in break-medium blocks. `height: auto` is retained to override the mobile rule (`.boot-layout--single-page`, specificity 0,2,0) which sets `height: calc(100vh - $admin-bar-height-big)`. Without this override, the black gap persists on desktop. * Fix: revert global min-height and scope layout fix to single-page mode --------- Unlinked contributors: sandipmaurya2611@gmail.com. Co-authored-by: sandipmaurya2611 <sandipmaurya2611@git.wordpress.org> Co-authored-by: shimotmk <shimotomoki@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
|
I just cherry-picked this PR to the wp/7.0 branch to get it included in the next release: 2cf4831 |
… page c… (#76764) * Boot: Fix black area below content when sidebar is taller than page content The `.boot-layout--single-page` selector (specificity 0,2,0) was setting `height: calc(100vh - $admin-bar-height-big)` for all viewports, but the desktop `@include mixins.break-medium` reset (specificity 0,1,0) could not override it. This locked content height to the viewport on desktop in single-page mode, creating a black gap below when scrolling. Fix: - Add matching-specificity `.boot-layout--single-page &` overrides inside the `break-medium` blocks for stage/inspector and canvas to reset `top` and `height` to `auto` on desktop. - Change `.boot-layout` from `height: 100%` to `min-height: 100%` so the layout container can grow when content exceeds the viewport. Closes #76478 * fix: remove redundant `top: auto` from single-page desktop styles `top` has no effect when `position: static` is applied in break-medium blocks. `height: auto` is retained to override the mobile rule (`.boot-layout--single-page`, specificity 0,2,0) which sets `height: calc(100vh - $admin-bar-height-big)`. Without this override, the black gap persists on desktop. * Fix: revert global min-height and scope layout fix to single-page mode --------- Unlinked contributors: sandipmaurya2611@gmail.com. Co-authored-by: sandipmaurya2611 <sandipmaurya2611@git.wordpress.org> Co-authored-by: shimotmk <shimotomoki@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
… page c… (#76764) * Boot: Fix black area below content when sidebar is taller than page content The `.boot-layout--single-page` selector (specificity 0,2,0) was setting `height: calc(100vh - $admin-bar-height-big)` for all viewports, but the desktop `@include mixins.break-medium` reset (specificity 0,1,0) could not override it. This locked content height to the viewport on desktop in single-page mode, creating a black gap below when scrolling. Fix: - Add matching-specificity `.boot-layout--single-page &` overrides inside the `break-medium` blocks for stage/inspector and canvas to reset `top` and `height` to `auto` on desktop. - Change `.boot-layout` from `height: 100%` to `min-height: 100%` so the layout container can grow when content exceeds the viewport. Closes #76478 * fix: remove redundant `top: auto` from single-page desktop styles `top` has no effect when `position: static` is applied in break-medium blocks. `height: auto` is retained to override the mobile rule (`.boot-layout--single-page`, specificity 0,2,0) which sets `height: calc(100vh - $admin-bar-height-big)`. Without this override, the black gap persists on desktop. * Fix: revert global min-height and scope layout fix to single-page mode --------- Unlinked contributors: sandipmaurya2611@gmail.com. Co-authored-by: sandipmaurya2611 <sandipmaurya2611@git.wordpress.org> Co-authored-by: shimotmk <shimotomoki@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
This updates the pinned hash from the `gutenberg` from `0d133bf7e7437d65d68a06551f3d613a7d8e4361` to `e2970ba736edb99e08fb369d4fb0c378189468ee`. The following changes are included: - WordPress/gutenberg#76478 Boot: Fix black area below content when sidebar is taller than page c… (WordPress/gutenberg#76764) - Style Book: Fix missing styles for classic themes in stylebook route (WordPress/gutenberg#76843) - RTC: Fix stuck "Join" link in post list when lock expires (WordPress/gutenberg#76795) - Icon: Fix center alignment in the editor for classic themes (WordPress/gutenberg#76878) - RTC: Fix notes not syncing between collaborative editors (WordPress/gutenberg#76873) - Latest Comments: Fix v1 deprecated block missing supports (WordPress/gutenberg#76877) - Connectors: Add Akismet as a default connector (WordPress/gutenberg#76828) - Restore with compaction update (WordPress/gutenberg#76872) - Improve JSDoc for abilities API (WordPress/gutenberg#76824) - Connectors: Replace plugin.slug with plugin.file (WordPress/gutenberg#76909) - Block visibility badge: use canvas iframe for viewport detection (WordPress/gutenberg#76889) - Connectors: Update help text from 'reset' to 'manage' (WordPress/gutenberg#76963) - Connectors: Hide Akismet unless already installed (WordPress/gutenberg#76962) - Wrap sync update processing in try/catch (WordPress/gutenberg#76968) - Backport: Improve validation and permission checks for `WP_HTTP_Polling_Sync_Server` (WordPress/gutenberg#76987) - Connectors: account for mu-plugins when resolving plugin.file status (WordPress/gutenberg#76994) A full list of changes can be found on GitHub: https://github.com/WordPress/gutenberg/compare/0d133bf7e7437d65d68a06551f3d613a7d8e4361…e2970ba736edb99e08fb369d4fb0c378189468ee. Log created with: git log --reverse --format="- %s" 0d133bf7e7437d65d68a06551f3d613a7d8e4361..e2970ba736edb99e08fb369d4fb0c378189468ee | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy See #64595. git-svn-id: https://develop.svn.wordpress.org/trunk@62209 602fd350-edb4-49c9-b593-d223f7449a82
This updates the pinned hash from the `gutenberg` from `0d133bf7e7437d65d68a06551f3d613a7d8e4361` to `e2970ba736edb99e08fb369d4fb0c378189468ee`. The following changes are included: - WordPress/gutenberg#76478 Boot: Fix black area below content when sidebar is taller than page c… (WordPress/gutenberg#76764) - Style Book: Fix missing styles for classic themes in stylebook route (WordPress/gutenberg#76843) - RTC: Fix stuck "Join" link in post list when lock expires (WordPress/gutenberg#76795) - Icon: Fix center alignment in the editor for classic themes (WordPress/gutenberg#76878) - RTC: Fix notes not syncing between collaborative editors (WordPress/gutenberg#76873) - Latest Comments: Fix v1 deprecated block missing supports (WordPress/gutenberg#76877) - Connectors: Add Akismet as a default connector (WordPress/gutenberg#76828) - Restore with compaction update (WordPress/gutenberg#76872) - Improve JSDoc for abilities API (WordPress/gutenberg#76824) - Connectors: Replace plugin.slug with plugin.file (WordPress/gutenberg#76909) - Block visibility badge: use canvas iframe for viewport detection (WordPress/gutenberg#76889) - Connectors: Update help text from 'reset' to 'manage' (WordPress/gutenberg#76963) - Connectors: Hide Akismet unless already installed (WordPress/gutenberg#76962) - Wrap sync update processing in try/catch (WordPress/gutenberg#76968) - Backport: Improve validation and permission checks for `WP_HTTP_Polling_Sync_Server` (WordPress/gutenberg#76987) - Connectors: account for mu-plugins when resolving plugin.file status (WordPress/gutenberg#76994) A full list of changes can be found on GitHub: https://github.com/WordPress/gutenberg/compare/0d133bf7e7437d65d68a06551f3d613a7d8e4361…e2970ba736edb99e08fb369d4fb0c378189468ee. Log created with: git log --reverse --format="- %s" 0d133bf7e7437d65d68a06551f3d613a7d8e4361..e2970ba736edb99e08fb369d4fb0c378189468ee | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy See #64595. Built from https://develop.svn.wordpress.org/trunk@62209 git-svn-id: http://core.svn.wordpress.org/trunk@61489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This updates the pinned hash from the `gutenberg` from `0d133bf7e7437d65d68a06551f3d613a7d8e4361` to `e2970ba736edb99e08fb369d4fb0c378189468ee`. The following changes are included: - WordPress/gutenberg#76478 Boot: Fix black area below content when sidebar is taller than page c… (WordPress/gutenberg#76764) - Style Book: Fix missing styles for classic themes in stylebook route (WordPress/gutenberg#76843) - RTC: Fix stuck "Join" link in post list when lock expires (WordPress/gutenberg#76795) - Icon: Fix center alignment in the editor for classic themes (WordPress/gutenberg#76878) - RTC: Fix notes not syncing between collaborative editors (WordPress/gutenberg#76873) - Latest Comments: Fix v1 deprecated block missing supports (WordPress/gutenberg#76877) - Connectors: Add Akismet as a default connector (WordPress/gutenberg#76828) - Restore with compaction update (WordPress/gutenberg#76872) - Improve JSDoc for abilities API (WordPress/gutenberg#76824) - Connectors: Replace plugin.slug with plugin.file (WordPress/gutenberg#76909) - Block visibility badge: use canvas iframe for viewport detection (WordPress/gutenberg#76889) - Connectors: Update help text from 'reset' to 'manage' (WordPress/gutenberg#76963) - Connectors: Hide Akismet unless already installed (WordPress/gutenberg#76962) - Wrap sync update processing in try/catch (WordPress/gutenberg#76968) - Backport: Improve validation and permission checks for `WP_HTTP_Polling_Sync_Server` (WordPress/gutenberg#76987) - Connectors: account for mu-plugins when resolving plugin.file status (WordPress/gutenberg#76994) A full list of changes can be found on GitHub: https://github.com/WordPress/gutenberg/compare/0d133bf7e7437d65d68a06551f3d613a7d8e4361…e2970ba736edb99e08fb369d4fb0c378189468ee. Log created with: git log --reverse --format="- %s" 0d133bf7e7437d65d68a06551f3d613a7d8e4361..e2970ba736edb99e08fb369d4fb0c378189468ee | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy See #64595. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62212 602fd350-edb4-49c9-b593-d223f7449a82
This updates the pinned hash from the `gutenberg` from `0d133bf7e7437d65d68a06551f3d613a7d8e4361` to `e2970ba736edb99e08fb369d4fb0c378189468ee`. The following changes are included: - WordPress/gutenberg#76478 Boot: Fix black area below content when sidebar is taller than page c… (WordPress/gutenberg#76764) - Style Book: Fix missing styles for classic themes in stylebook route (WordPress/gutenberg#76843) - RTC: Fix stuck "Join" link in post list when lock expires (WordPress/gutenberg#76795) - Icon: Fix center alignment in the editor for classic themes (WordPress/gutenberg#76878) - RTC: Fix notes not syncing between collaborative editors (WordPress/gutenberg#76873) - Latest Comments: Fix v1 deprecated block missing supports (WordPress/gutenberg#76877) - Connectors: Add Akismet as a default connector (WordPress/gutenberg#76828) - Restore with compaction update (WordPress/gutenberg#76872) - Improve JSDoc for abilities API (WordPress/gutenberg#76824) - Connectors: Replace plugin.slug with plugin.file (WordPress/gutenberg#76909) - Block visibility badge: use canvas iframe for viewport detection (WordPress/gutenberg#76889) - Connectors: Update help text from 'reset' to 'manage' (WordPress/gutenberg#76963) - Connectors: Hide Akismet unless already installed (WordPress/gutenberg#76962) - Wrap sync update processing in try/catch (WordPress/gutenberg#76968) - Backport: Improve validation and permission checks for `WP_HTTP_Polling_Sync_Server` (WordPress/gutenberg#76987) - Connectors: account for mu-plugins when resolving plugin.file status (WordPress/gutenberg#76994) A full list of changes can be found on GitHub: https://github.com/WordPress/gutenberg/compare/0d133bf7e7437d65d68a06551f3d613a7d8e4361…e2970ba736edb99e08fb369d4fb0c378189468ee. Log created with: git log --reverse --format="- %s" 0d133bf7e7437d65d68a06551f3d613a7d8e4361..e2970ba736edb99e08fb369d4fb0c378189468ee | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy See #64595. Built from https://develop.svn.wordpress.org/branches/7.0@62212 git-svn-id: http://core.svn.wordpress.org/branches/7.0@61492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
… page c… (#76764) * Boot: Fix black area below content when sidebar is taller than page content The `.boot-layout--single-page` selector (specificity 0,2,0) was setting `height: calc(100vh - $admin-bar-height-big)` for all viewports, but the desktop `@include mixins.break-medium` reset (specificity 0,1,0) could not override it. This locked content height to the viewport on desktop in single-page mode, creating a black gap below when scrolling. Fix: - Add matching-specificity `.boot-layout--single-page &` overrides inside the `break-medium` blocks for stage/inspector and canvas to reset `top` and `height` to `auto` on desktop. - Change `.boot-layout` from `height: 100%` to `min-height: 100%` so the layout container can grow when content exceeds the viewport. Closes #76478 * fix: remove redundant `top: auto` from single-page desktop styles `top` has no effect when `position: static` is applied in break-medium blocks. `height: auto` is retained to override the mobile rule (`.boot-layout--single-page`, specificity 0,2,0) which sets `height: calc(100vh - $admin-bar-height-big)`. Without this override, the black gap persists on desktop. * Fix: revert global min-height and scope layout fix to single-page mode --------- Unlinked contributors: sandipmaurya2611@gmail.com. Co-authored-by: sandipmaurya2611 <sandipmaurya2611@git.wordpress.org> Co-authored-by: shimotmk <shimotomoki@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
…ontent
The
.boot-layout--single-pageselector (specificity 0,2,0) was settingheight: calc(100vh - $admin-bar-height-big)for all viewports, but the desktop@include mixins.break-mediumreset (specificity 0,1,0) could not override it. This locked content height to the viewport on desktop in single-page mode, creating a black gap below when scrolling.Fix:
.boot-layout--single-page &overrides inside thebreak-mediumblocks for stage/inspector and canvas to resettopandheighttoautoon desktop..boot-layoutfromheight: 100%tomin-height: 100%so the layout container can grow when content exceeds the viewport.Closes #76478
What?
Closes
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Use of AI Tools