Build: Add vendorScripts config to build packages from node_modules #74343
+238
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for building vendor packages (like React) from node_modules instead of relying on pre-built UMD bundles. This is needed for React 19+ which no longer ships UMD builds. New `vendorScripts` config in `wpPlugin`: - `name`: Package name (e.g., 'react', 'react/jsx-runtime') - `global`: Global variable name (e.g., 'React', 'ReactJSXRuntime') - `handle`: WordPress script handle (e.g., 'react', 'react-jsx-runtime') - `dependencies`: Array of dependency handles The bundleVendorScript function: - Resolves packages from node_modules using require.resolve() - Builds IIFE bundles with proper globalName - Externalizes other vendor packages to avoid duplication - Generates .asset.php files with dependencies and version hash Default vendor externals are preserved in wordpress-externals-plugin for third-party plugins that rely on WordPress core providing these scripts.
Member
|
I think the script bundles latest version of the scripts is causing the CI failures. |
jsnajdr
reviewed
Jan 7, 2026
| } = config; | ||
|
|
||
| const { createRequire } = await import( 'module' ); | ||
| const require = createRequire( import.meta.url ); |
Member
There was a problem hiding this comment.
Instead of resolving the package ourselves, we could tell esbuild to do it for us. Just tell it to bundle this synthetic module:
export * from 'react';
where react is the ${name} value. With the iife format and globalName set to React, it will produce a script that assigns all react exports to the React global. Exactly what we want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note This is fully vibe-coded with my own instructions about how it should be API wise. I also didn't test it yet.
Summary
Adds support for building vendor packages (like React) directly from
node_modulesinstead of relying on pre-built UMD bundles. This addresses the React 19 upgrade blocker where UMD builds are no longer shipped.Changes
vendorScriptsconfig inwpPlugin(package.json)bundleVendorScript()function that bundles packages from node_modules into IIFE formatwordpress-externals-pluginto accept vendor scripts config while preserving defaults for third-party pluginsConfiguration
Build Output
build/scripts/react/index.min.js (~7KB) - exposes window.React
build/scripts/react-dom/index.min.js (~135KB) - exposes window.ReactDOM
build/scripts/react-jsx-runtime/index.min.js (~1KB) - exposes window.ReactJSXRuntime
Test plan
Build completes successfully with npm run build
Vendor scripts are bundled and registered in build/scripts/index.php
Asset files have correct dependencies
Test in browser that React globals are exposed correctly