Skip to content

Modal: Replace justify-content: left with flex-start in modal header#71993

Merged
t-hamano merged 1 commit intoWordPress:trunkfrom
ivan-ottinger:update/modal-heading-alignment-styling
Oct 2, 2025
Merged

Modal: Replace justify-content: left with flex-start in modal header#71993
t-hamano merged 1 commit intoWordPress:trunkfrom
ivan-ottinger:update/modal-heading-alignment-styling

Conversation

@ivan-ottinger
Copy link
Copy Markdown
Contributor

@ivan-ottinger ivan-ottinger commented Oct 1, 2025

What?

Closes #71997

The PR changes justify-content: left; to justify-content: flex-start; for the Modal block heading alignment.

ℹ️ I did not add a new record to the changelog for such a small change, but happy to update it if needed.

Why?

With the proposed change there's no need for extra RTL styling adjustment to handle Modal's heading alignment.

How?

Described above - in the What? section.

Testing Instructions

  1. Open a post for editing.
  2. Head over to the Preferences modal:
Markup on 2025-10-01 at 12:04:45
  1. Review the styling in the browser inspector:
Markup on 2025-10-01 at 11:48:55
  1. Switch site locale to one of the RTL languages, go back to the Preferences modal and confirm the alignment is correct:
Markup on 2025-10-01 at 11:50:05

Testing Instructions for Keyboard

N/A

Screenshots or screencast

Added in the content above.

@ivan-ottinger ivan-ottinger marked this pull request as ready for review October 1, 2025 11:12
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 1, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @katinthehatsite.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: katinthehatsite.

Co-authored-by: ivan-ottinger <ivanottinger@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano added [Type] Code Quality Issues or PRs that relate to code quality [Package] Components /packages/components labels Oct 1, 2025
Copy link
Copy Markdown

@katinthehatsite katinthehatsite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me 👍

Copy link
Copy Markdown
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! No new changelog record would be necessary.

@t-hamano t-hamano added the props-bot Manually triggers Props Bot to ensure the list of props is up to date. label Oct 2, 2025
@github-actions github-actions bot removed the props-bot Manually triggers Props Bot to ensure the list of props is up to date. label Oct 2, 2025
@t-hamano t-hamano merged commit 8a4cb31 into WordPress:trunk Oct 2, 2025
94 of 101 checks passed
@github-actions github-actions bot added this to the Gutenberg 21.9 milestone Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposal: Replace justify-content: left with flex-start in the Modal component header

3 participants