Remove the extra font-size override for the select control on medium layouts#70619
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
left a comment
There was a problem hiding this comment.
LGTM! This CSS is no longer needed, but I guess we forgot to remove it.
Could you add an entry to the CHANGELOG file? Perhaps this would fit in the Bug Fixes section.
@t-hamano , thanks for the review and the suggestions. I added an entry in the changelog 2ce72cd |
What?
Closes #70617
The input control changes the font-size when the viewport is lower than 600px but the SelectControl changes before, at 782px. I think this is an error and this PR fixes it and makes the SelectControl consistent to the regular input.
Change introduced at #10957.
Why?
It's weird to see the select control change the font-size when the rest of the compnents stay the same.
How?
Testing Instructions
npm run storybook:devselect-control-changes-at-the-same-width-as-input-control.mp4
Testing Instructions for Keyboard
N/A
Screenshots or screencast