Skip to content

Remove the extra font-size override for the select control on medium layouts#70619

Merged
t-hamano merged 2 commits intoWordPress:trunkfrom
sejas:fix/select-control-responsive-font-size
Jul 8, 2025
Merged

Remove the extra font-size override for the select control on medium layouts#70619
t-hamano merged 2 commits intoWordPress:trunkfrom
sejas:fix/select-control-responsive-font-size

Conversation

@sejas
Copy link
Copy Markdown
Contributor

@sejas sejas commented Jul 4, 2025

What?

Closes #70617

The input control changes the font-size when the viewport is lower than 600px but the SelectControl changes before, at 782px. I think this is an error and this PR fixes it and makes the SelectControl consistent to the regular input.

Change introduced at #10957.

Why?

It's weird to see the select control change the font-size when the rest of the compnents stay the same.

How?

Testing Instructions

select-control-changes-at-the-same-width-as-input-control.mp4

Testing Instructions for Keyboard

N/A

Screenshots or screencast

Before After
Screenshot 2025-07-04 at 11 39 36 Screenshot 2025-07-04 at 11 55 29

@sejas sejas requested a review from ajitbohra as a code owner July 4, 2025 10:57
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 4, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: sejas <antoniosejas@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@sejas sejas changed the title Remove the extra font-size override for the select control on responsive layouts Remove the extra font-size override for the select control on medium layouts Jul 4, 2025
@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Package] Components /packages/components labels Jul 4, 2025
Copy link
Copy Markdown
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This CSS is no longer needed, but I guess we forgot to remove it.

Could you add an entry to the CHANGELOG file? Perhaps this would fit in the Bug Fixes section.

@sejas
Copy link
Copy Markdown
Contributor Author

sejas commented Jul 7, 2025

Could you add an entry to the CHANGELOG file? Perhaps this would fit in the Bug Fixes section.

@t-hamano , thanks for the review and the suggestions. I added an entry in the changelog 2ce72cd

@t-hamano t-hamano merged commit cec75cc into WordPress:trunk Jul 8, 2025
60 checks passed
@github-actions github-actions bot added this to the Gutenberg 21.2 milestone Jul 8, 2025
@sejas sejas deleted the fix/select-control-responsive-font-size branch July 8, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Components /packages/components [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SelectControl has a larger font size in smaller viewports

2 participants