Card: Adjust padding to maintain visual balance across different sizes#70344
Closed
arthur791004 wants to merge 2 commits intotrunkfrom
Closed
Card: Adjust padding to maintain visual balance across different sizes#70344arthur791004 wants to merge 2 commits intotrunkfrom
arthur791004 wants to merge 2 commits intotrunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Closed
8 tasks
|
Size Change: -8 B (0%) Total Size: 1.85 MB
ℹ️ View Unchanged
|
8 tasks
9 tasks
Contributor
Author
|
@ciampo Do you have any suggestions on this? Thank you! |
Member
|
Have we run this by @WordPress/gutenberg-design? |
Contributor
|
I think #72511 is a more rounded solution here. |
Contributor
Author
|
Let's close this in favor of #72511. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow up to Automattic/wp-calypso#103988 (comment), it would be better to update the
Cardcomponent to support equal padding values across all sizes, especially for the predefinedmediumandlargesizes. Currently, the padding is unbalanced — typically with more space on the horizontal sides than the vertical ones. This inconsistency leads to various layout and spacing issues.Why?
Ensure better visual alignment and reduce manual spacing overrides across the UI.
How?
Update the padding for both medium and large sizes in the Card component to improve visual consistency and reduce the need for ad hoc spacing fixes across the UI.
That said, I'm not entirely sure whether updating the existing sizes is the best approach, as it could introduce unintended layout changes in areas already using them. An alternative could be to introduce a new size—somewhere between medium and large—with padding set to
space( 6 )andspace( 8 )respectively.However, adding a new in-between size might feel a bit awkward and could complicate the size variants further. Open to thoughts on the best path forward here 🙂
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast