Skip to content

Link UI: Placeholder text#68849

Open
dhananjaykuber wants to merge 1 commit intoWordPress:trunkfrom
dhananjaykuber:feat/update-placeholder-text-of-search-input
Open

Link UI: Placeholder text#68849
dhananjaykuber wants to merge 1 commit intoWordPress:trunkfrom
dhananjaykuber:feat/update-placeholder-text-of-search-input

Conversation

@dhananjaykuber
Copy link
Copy Markdown
Contributor

Fixes #56378

What?

Update the placeholder text to "Search for a Page/Post or type URL".

Why?

When users first open the Link UI it's not clear what they are meant to do. I have seen users who thought they were only able to enter URLs, and that it wouldn't work for draft pages/pages.

Testing Instructions

  1. Click on 'Add Link' option in Toolbar
  2. Check the placeholder text of search input is more clear

Screenshots or screencast

Before

Screenshot 2025-01-23 at 2 48 53 PM

After

Screenshot 2025-01-23 at 10 51 32 AM

@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dhananjaykuber <dhananjaykuber@git.wordpress.org>
Co-authored-by: scruffian <scruffian@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano added [Type] Enhancement A suggestion for improvement. [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) labels Jan 25, 2025
Copy link
Copy Markdown
Contributor

@getdave getdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.

The problem is that this UI can be configured to search for other types such as Taxonomies and things like that. In that context this won't make much sense.

Perhaps you could make the test conditional?

Personally I would lean towards keeping things simple however - the original text is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Link UI: Show suggestions by default

3 participants