Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
getdave
left a comment
There was a problem hiding this comment.
Thank you for the PR.
The problem is that this UI can be configured to search for other types such as Taxonomies and things like that. In that context this won't make much sense.
Perhaps you could make the test conditional?
Personally I would lean towards keeping things simple however - the original text is good.
Fixes #56378
What?
Update the placeholder text to "Search for a Page/Post or type URL".
Why?
When users first open the Link UI it's not clear what they are meant to do. I have seen users who thought they were only able to enter URLs, and that it wouldn't work for draft pages/pages.
Testing Instructions
Screenshots or screencast
Before
After