Closed
Conversation
|
Size Change: +2.4 kB (+0.13%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
…ata-form-pattern-creation
…ata-form-pattern-creation
…ata-form-pattern-creation
Mamaduka
added
[Feature] Patterns
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
Contributor
Author
|
I'm going to close this PR because it is outdated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR initiates an exploration of how DataForm should handle validation, focusing on the Pattern Creation modal. Currently, the "save" button is disabled when the name input is empty.
Screen.Capture.on.2024-11-27.at.14-43-42.mp4
With DataForm, we aim to further enhance validation by displaying an error message when:
Screen.Capture.on.2024-11-27.at.15-01-56.mp4
This PR adapts the existing behavior to use the DataForm library. A separate PR will address displaying the error message when the input is touched and empty:
Screen.Capture.on.2024-11-27.at.15-14-40.mov
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast