Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
tyxla
added
[Type] Regression
This was referenced Oct 22, 2024
|
Size Change: -7 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
ciampo
approved these changes
Oct 22, 2024
Mamaduka
approved these changes
Oct 22, 2024
sirreal
approved these changes
Oct 22, 2024
Member
sirreal
left a comment
sirreal
left a comment
There was a problem hiding this comment.
Seems reasonable, thanks for the fix 👍
Member
|
Thanks! I wonder why the tests didn't report issues in the original PR 🤔 |
Member
Related #66213 (comment) |
Contributor
|
Thanks for the quick follow-up |
Contributor
|
Looks like just a rare case where two PRs got merged almost at the same time and both with tests passing. |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: sirreal <jonsurrell@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fix a missed instance from #66213.
Why?
It's causing errors 😉
How?
Just using the right var.
Testing Instructions
#66213 testing instructions should do.
Testing Instructions for Keyboard
Same
Screenshots or screencast