Fix output buffering for cross-origin isolation#65701
Conversation
Improves compatibility with hosts who don't already serve wasm files with the correct mime type
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
felixarntz
left a comment
There was a problem hiding this comment.
Two questions, but overall LGTM.
| // Only send the header when the buffer is not being cleaned. | ||
| if ( ( $phase & PHP_OUTPUT_HANDLER_CLEAN ) === 0 ) { |
There was a problem hiding this comment.
Can you explain why this is no longer relevant?
I wouldn't have asked if it hadn't been here before, but why was it there before and is now being removed?
There was a problem hiding this comment.
Well it was there before because I thought I needed it, but turns out it doesn't work, so I just removed it.
There was a problem hiding this comment.
FWIW, the PL plugin includes this: WordPress/performance#1443
And the Optimization Detective plugin: WordPress/performance#1317
In my testing it worked, although I wrestled with this one for awhile to replicate the scenario where it would be relevant.
There was a problem hiding this comment.
IDK what's different here, but this change here fixes the issue for me and would unblock further work, so I'd appreciate an approval
)" This reverts commit 35d2718.
What?
This is a quick follow-up to #64650 with two simple fixes:
Note: this is only applicable when the client-side media processing experiment is enabled.
Why?
See #61447
How?
Testing Instructions
N/A
Testing Instructions for Keyboard
Screenshots or screencast