DataViews: Use Dropdown for views config dialog#65314
Merged
ntsekouras merged 1 commit intotrunkfrom Sep 13, 2024
Merged
Conversation
ntsekouras
added
[Type] Code Quality
ntsekouras
requested review from
ciampo,
jameskoster,
mirka and
youknowriad
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +20 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
jameskoster
approved these changes
Sep 13, 2024
Contributor
jameskoster
left a comment
jameskoster
left a comment
There was a problem hiding this comment.
Good spot, that's much better.
ntsekouras
force-pushed
the
dataviews-view-config-use-dropdown
branch
from
79a5fac to
bedc60b
Compare
Contributor
|
Hey @ntsekouras , catching up just now Overall the changes in this PR look good.
That seems to be a bit of a loop that happens when you click on the toggle button: popover loses focus, which triggers the I agree that this behaviour is weird, but I can't think of many ways to fix this without introducing potentially breaking changes. Using a
Sounds good. Also noting that, by default,
Modality of popover-based components is a tricky topic that we've been discussing for a while (#63674). A TL;DR is that we should be careful when using modal UI, since it's got big implications for users. What is certain is that, as we transition popover-based components to The current popover component is a bit of a mess: it implements some "modal"-like behaviour (like closing on blur), but not the full deal. With a new version of |
ciampo
reviewed
Sep 16, 2024
| padding: $grid-unit-20; | ||
| font-size: $default-font-size; | ||
| line-height: $default-line-height; | ||
| .components-popover__content { |
Contributor
There was a problem hiding this comment.
Using internal component classnames can really hinder our ability to make changes to the components without causing unintended breaking changes.
In this case, we can use the DropdownContentWrapper component, which is used specifically to set custom padding for dropdown content. I will open a separate PR to make the change
Contributor
Author
There was a problem hiding this comment.
Thank you for your follow up! I wasn't aware of DropdownContentWrapper.
ciampo
reviewed
Sep 16, 2024
| setDensity={ setDensity } | ||
| <Dropdown | ||
| popoverProps={ { placement: 'bottom-end', offset: 9 } } | ||
| contentClassName="dataviews-view-config" |
Contributor
There was a problem hiding this comment.
The dataviews-view-config classname is already used for the VStack in the DataviewsViewConfigContent, which causes some styles to be unexpectedly applied to two elements at the same time. We should probably remove this instance.
ciampo
reviewed
Sep 16, 2024
| density={ density } | ||
| setDensity={ setDensity } | ||
| <Dropdown | ||
| popoverProps={ { placement: 'bottom-end', offset: 9 } } |
Contributor
There was a problem hiding this comment.
This could be extracted as a constant object, to avoid passing a new instance every re-render
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
I observed in DataViews view config dialog that when you clicked the
trigger, the dialog would always reopen. After checking, Riad also mentions some inconsistencies and the not necessary usage of the lower level Popover component:offsetfor this for now.modalbehavior is something implemented only in DropdownMenuV2 right now. This should be handled properly I think when theDropdownV2is implemented. --cc @ciampo @mirkaIt's not an impactful change and while it doesn't fix the
modalbehavior, I think it can be merged..Testing Instructions
In DataViews the view config dialog should be exactly as before, except: