Normalize spacing in Layout hook controls#65132
Merged
Conversation
mirka
added
[Type] Bug
mirka
commented
Sep 6, 2024
Comment on lines
-11
to
-14
| .block-editor-hooks__layout-controls-reset { | ||
| display: flex; | ||
| justify-content: flex-end; | ||
| margin-bottom: $grid-unit-30; |
Comment on lines
-1
to
-5
| .block-editor-hooks__layout-controls-units { | ||
| display: flex; | ||
| flex-direction: column; | ||
| gap: $grid-unit-20; | ||
| } |
| } | ||
|
|
||
| .block-editor-hooks__layout-controls-helptext { | ||
| .block-editor-hooks__layout-constrained-helptext { |
Member
Author
There was a problem hiding this comment.
Renamed the class for consistency with the JS file name. (Naming it controls seems too broad to avoid collisions.)
| </div> | ||
| </> | ||
| ) } | ||
| { allowJustification && ( |
Member
Author
There was a problem hiding this comment.
I don't think any Core blocks show this Justification control, but I made sure that the spacing looks correct even with the Justification control showing. (It is correct in trunk, and still correct here)
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
2 tasks
|
Size Change: -46 B (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
mirka
changed the title
tyxla
approved these changes
Sep 9, 2024
| margin-bottom: 0; | ||
| } | ||
|
|
||
| .block-editor-hooks__layout-controls-reset { |
Member
There was a problem hiding this comment.
Is there any chance any of these removed classes were used for additional styling?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite for #64526
What?
Removes some excessive margin in the controls for the Layout block editor hook.
The following Core blocks use this hook:
How?
The structure is reworked a bit for efficiency — see inline comments.
Testing Instructions
Insert any of the affected blocks in the editor and see the block inspector. To enable the Justification control, it will be easiest to change this condition to
true:gutenberg/packages/block-editor/src/layouts/constrained.js
Line 131 in 60d338f
Screenshots or screencast