Block Bindings: Add warning in attributes connected to invalid sources#65002
Merged
SantosGuillamot merged 3 commits intotrunkfrom Sep 3, 2024
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
SantosGuillamot
added
[Type] Enhancement
SantosGuillamot
assigned
cbravobernal and unassigned
gziolo,
jasmussen,
artemiomorales and
cbravobernal
SantosGuillamot
requested review from
artemiomorales,
cbravobernal,
gziolo and
jasmussen
Member
|
Just did a quick test. Works as expected and looks good: 
|
|
Size Change: +30 B (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
Contributor
|
I won't have time to look deeply today, but can work! The line-height here is off, though:
That may be component level, and therefore not a blocker. But it's too tall a lineheight/gap. |
|
Flaky tests detected in 798d4dd. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10682780799
|
Contributor
Author
I think you are right and it is not related to this pull request. I can see the same problem in |
Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>
64 tasks
SantosGuillamot
deleted the
try/alternative-warning-to-undefined-bindings-source
branch
Contributor
Author
|
@jasmussen Regarding your comment: I have opened a follow-up PR to have the same line-height for the attribute and the key: #65007. It doesn't change the line height of the Text component but, if that is changed in the future, it ensures it is properly applied to both places. I hope that's fine. |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Alternative to #64893
Instead of stopping the rendering of the block, just shows the default content and add a warning message in the connections panel.
Why?
It is less invasive, especially for use cases where the invalid attribute wouldn't break the block.
How?
I'm just checking if the source exists and, if not, change the message and add the
isDestructiveproperty of theTextcomponent.Testing Instructions
Check that the warning is shown.
Check the paragraph still shows the default content.
You can repeat the process with an image with multiple attributes: