Button: Add lint rule for 40px size prop usage#64835
Merged
Conversation
mirka
commented
Aug 27, 2024
| <VStack spacing="5"> | ||
| <Text> | ||
| { `Are you sure you want to delete "${ item.title }"?` } | ||
| { `Are you sure you want to delete "${ item?.title }"?` } |
Member
Author
There was a problem hiding this comment.
This feature currently seems to be broken in Storybook. Quick patched with optional chaining so it at least doesn't crash.
Member
There was a problem hiding this comment.
Thanks for the report! I've prepared a fix at #64901
| <form onSubmit={ close }> | ||
| <input type="url" value={ url } onChange={ setUrl } /> | ||
| <Button | ||
| __next40pxDefaultSize |
Member
Author
There was a problem hiding this comment.
Styling already looks broken in trunk. Upsizing the buttons since it doesn't seem to matter in this context.
Contributor
There was a problem hiding this comment.
😞 we could try to propose a fix if it's a quick one
Member
Author
There was a problem hiding this comment.
Doesn't seem quick, but maybe something that can be fixed in conjunction with #64709.
| }; | ||
| } )( ( props ) => <Button onClick={ props.increment } /> ); | ||
| } )( ( props ) => ( | ||
| <Button __next40pxDefaultSize onClick={ props.increment } /> |
Member
Author
There was a problem hiding this comment.
Doesn't matter because this is a test.
28 tasks
mirka
requested review from
adamziel,
ajitbohra,
draganescu,
ellatrix,
getdave,
kevin940726,
michalczaplinski,
nerrad,
peterwilsoncc and
tellthemachines
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +363 B (+0.02%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
ciampo
approved these changes
Aug 27, 2024
Contributor
ciampo
left a comment
ciampo
left a comment
There was a problem hiding this comment.
LGTM 🚀
This PR is a reminder about why we're so cautious when dealing with Button 😅 So many usages!
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
* Fix in URLPopover story * Fix in Dataviews story * Fix in WithDispatch test * Add todo comments * Add lint rule Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org>
3 tasks
Contributor
|
It seems like the lint rule would ideally except buttons that have I suppose that because gutenberg/packages/edit-site/src/components/site-hub/index.js Lines 80 to 82 in f073488 |
Member
Author
Right, the lint rule doesn't cover that. For what it's worth, the actual console warning will take the variant into account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #63871
What?
Add a lint rule to prevent people from introducing new usages of Button that do not adhere to the new default size, while adding a TODO note on existing violations.
I also went ahead and fixed the three straightforward ones (tests and stories).
Why?
Some components have a large number of existing violations, and it would take some time to safely switch them all. We can more efficiently move everything to the new 40px sizes if we immediately start preventing new violations from entering the codebase, as well as add TODO comments on the existing violations so people who come across that code are more likely to fix it on the spot.
How?
I codemod'ed all existing violations to:
Testing Instructions
The lint error should trigger if you add a Button with no
__next40pxDefaultSizeorsizeprop.