Skip to content

Paste: fix blob uploading #64479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ellatrix merged 4 commits into from
Aug 15, 2024
Merged

Paste: fix blob uploading #64479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f2edcf5
Paste: fix blob uploading
ellatrix Aug 13, 2024
a1ddc96
Add e2e test
ellatrix Aug 13, 2024
757f8e4
Fix attribute name for Video block
Mamaduka Aug 14, 2024
d5636d7
Check if e2e test is the cause
ellatrix Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/block-library/src/image/transforms.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* WordPress dependencies
*/
import { createBlobURL } from '@wordpress/blob';
import { createBlobURL, isBlobURL } from '@wordpress/blob';
import { createBlock, getBlockAttributes } from '@wordpress/blocks';
import { dispatch } from '@wordpress/data';
import { store as noticesStore } from '@wordpress/notices';
Expand Down Expand Up @@ -123,6 +123,12 @@ const transforms = {
anchor,
}
);

if ( isBlobURL( attributes.url ) ) {
attributes.blob = attributes.url;
delete attributes.url;
}

return createBlock( 'core/image', attributes );
},
},
Expand Down
6 changes: 5 additions & 1 deletion packages/block-library/src/video/transforms.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* WordPress dependencies
*/
import { createBlobURL } from '@wordpress/blob';
import { createBlobURL, isBlobURL } from '@wordpress/blob';
import { createBlock } from '@wordpress/blocks';

const transforms = {
Expand Down Expand Up @@ -92,6 +92,10 @@ const transforms = {
poster: videoElement.getAttribute( 'poster' ) || undefined,
src: videoElement.getAttribute( 'src' ) || undefined,
};
if ( isBlobURL( attributes.src ) ) {
attributes.blob = attributes.src;
delete attributes.src;
}
return createBlock( 'core/video', attributes );
},
},
Expand Down