CustomSelectControlV2: do not flip popover if legacy adapter#63357
CustomSelectControlV2: do not flip popover if legacy adapter#63357
Conversation
|
Flaky tests detected in 061b9e2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9887447341
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
be753a3 to
061b9e2
Compare
061b9e2 to
31195e6
Compare
…ss#63357) * CustomSelectContorlV2: do not flip if legacy adapter * CHANGELOG --- Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: DaniGuardiola <daniguardiola@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
What?
Part of #55023
Do not allow the select popover in the
CustomSelectControlV2 legacy adapter to flip when there isn't much space to render below the trigger button.Why?
This matches more closely the behavior of the legacy, downshift-based component and prevents (avoids it without solving) the issue reported in #63180
How?
By setting the
flipproperty tofalseon the ariakit select popoverTesting Instructions
CustomSelectControlV2legacy adapter and open the select popoverScreenshots or screencast
Kapture.2024-07-10.at.16.32.46.mp4
Kapture.2024-07-10.at.16.36.45.mp4