Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
tyxla
left a comment
There was a problem hiding this comment.
Tests as advertised and code looks good 👍 🚀
I'm starting to prefer this solution design-wise, too.
e36d376 to
43cb26f
Compare
|
Flaky tests detected in 43cb26f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9838189617
|
* CustomSelectControlV2: keep item checkmark top aligned * CHANGELOG --- Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
* CustomSelectControlV2: keep item checkmark top aligned * CHANGELOG --- Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
What?
Part of #55023
Extracted from #63139
Why?
Design feedback
How?
By using flexbox's alignment options + adding a small margin to preserve the correct vertical alignment with the first line of item text.
Testing Instructions
CustomSelectControlV2Legacy "With Hints" exampleScreenshots or screencast