CustomSelectControl V2 legacy adapter: fix trigger button font size#63131
Merged
CustomSelectControl V2 legacy adapter: fix trigger button font size#63131
Conversation
ciampo
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
85 tasks
tyxla
approved these changes
Jul 4, 2024
Member
tyxla
left a comment
tyxla
left a comment
There was a problem hiding this comment.
Confirmed to always be 16px on mobile layouts, just like on the v1:
Small size:
Default size:
(Unstable) Large size:
Font size is 16px for all: ✅
This was referenced Jul 4, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
* CustomSelectControl V2 legacy adapter: fix trigger button font size * CHANGELOG --- Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of #55023
Update the font size of the
CustomSelectControlV2 legacy adapter to use the same underlying logic as V1Why?
V2 legacy adapter should match V1 styles
How?
The V1 implementation re-uses some
SelectControlstyles, which in turn use a utility fromInputControlto determine the font size.I've updated
CustomSelectControlV2to use the same utility.Testing Instructions
In Storybook, open
CustomSelectControlV2legacy adapter examples:16pxregardless of thesizeprop for screens narrower than600px600px, the font size is11pxwhen thesizeissmall, and13pxotherwiseNote
During my testing, I realised that
CustomSelectControlV1 has a bug for which the font size doesn't change as it should according to the size for screens wider than600px— for some reason, thesizedoesn't get correctly passed to thefontSizeStylesutility, and as a consequence the default font size is always applied (13px). You can verify the buggy behaviour by settingsize="small"onCustomSelectControlV1 and observe how the font size is still13pxinstead of11px.I don't think we should spend time fixing it, since the V1 implementation is soon going away.