CustomSelectControlV2: fix select popover content overflow#62844
Merged
CustomSelectControlV2: fix select popover content overflow#62844
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This was referenced Jun 25, 2024
634913e to
d14775f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of #55023
Set a minimum width for the
CustomSelectControlV2's select popoverWhy?
To avoid content overflowing or horizontal scrolling inside the popover
How?
min-width: fit-contentto the popover wrapper to avoid the content from overflowingslide={false}on Ariakit'sSelectPopoverto keep the popover anchored to its trigger while scrolling the page horizontallyTesting Instructions
Click to expand
CustomSelectControlV2Legacy "With Long Labels" storyScreenshots or screencast
cscv1.-.item.wrapping.mp4
cscv2.-.item.wrapping.-.before.mp4
cscv2.-.item.wrapping.-.after.mp4