[Mobile] - Update components imports#61109
Merged
geriux merged 24 commits intofix/mobile-circular-dependenciesfrom May 17, 2024
Merged
[Mobile] - Update components imports#61109geriux merged 24 commits intofix/mobile-circular-dependenciesfrom
geriux merged 24 commits intofix/mobile-circular-dependenciesfrom
Conversation
added 23 commits
April 25, 2024 19:28
geriux
added
[Type] Enhancement
|
Size Change: 0 B Total Size: 1.74 MB ℹ️ View Unchanged
|
geriux
added
the
Mobile App - Automation
…lar-dependencies-components
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
Author
geriux
pushed a commit
that referenced
this pull request
May 17, 2024
…#61102) * Components - Move mobile global styles context to the block editor package * Components - Remove moved files * Components - Move mobile AudioPlayer to Block Editor components * Update moved components * Components - Update exports for native Block Editor and Component packages * Update imports in block files * Update imports for format library and color settings * Update imports in block editor and editor components * [Mobile] - Update components imports (#61109) * Components - AutoComplete - Fix components imports * Components - ColorIndicator - Fix components imports * Components - ColorPicker - Fix components imports * Components - CustomGradient - Fix components imports * Components - DashIcon - Fix components imports * Components - Draggable - Fix components imports * Components - DropdownMenu - Fix components imports * Components - FocalPointPicker - Fix components imports * Components - FontSizePicker - Fix components imports * Components - AutoCompletion - Fix components imports * Components - BottomSheet - Fix components imports * Components - ColorSettings - Fix components imports * Components - FocalPointSettingsPanel - Fix components imports * Components - Gradient - Fix components imports * Components - Image - Fix components imports * Components - LinkPicker - Fix components imports * Components - LinkSettings - Fix components imports * Components - MediaEdit - Fix components imports * Components - Picker - Fix components imports * Components - Panel - Fix components imports * Components - QueryControls - Fix components imports * Components - SearchControl - Fix components imports * Components - Tooltip - Fix components imports Co-authored-by: geriux <geriux@git.wordpress.org> Co-authored-by: twstokes <twstokes@git.wordpress.org> * Mobile - Update changelog --------- Co-authored-by: geriux <geriux@git.wordpress.org> Co-authored-by: twstokes <twstokes@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Part of #61102
Addresses #52692
What?
This PR is a follow-up of #61102 to remove the pending circular dependencies within the
componentspackage.Why?
The initial prompt started at #27751 so this is a continuation of the ongoing effort to remove/reduce circular dependencies.
How?
Updating the imports to use internal dependencies from the
componentspackage.As mentioned in the parent PR, before these changes, we had 80 warnings of require cycles, with these two PRs we will have only 45 remaining, none of those are from the components package anymore so we can focus on the rest in future iterations.
Testing Instructions
CI checks should pass.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A