Block Bindings: Update source registration syntax and remove APIs that should be private

[michalczaplinski]

There are a few changes in this PR:

Following WordPress/wordpress-develop#5888 I've:

• Moved the source registration to an "array" syntax
• Removed the replace_html() method of the WP_Block_Bindings class
• Moved the body of replace_html() from the WP_Block_Bindings class to the block-bindings.php file

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ lib/compat/wordpress-6.5/block-bindings/block-bindings.php
❔ lib/compat/wordpress-6.5/block-bindings/class-wp-block-bindings.php
❔ lib/compat/wordpress-6.5/block-bindings/sources/pattern.php
❔ lib/compat/wordpress-6.5/block-bindings/sources/post-meta.php
❔ lib/compat/wordpress-6.5/blocks.php

[github-actions]

Flaky tests detected in c9a245e.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7644439081
📝 Reported issues:

• [Flaky Test] Only the first block is an empty paragraph block #58161 in /test/e2e/specs/editor/blocks/paragraph.spec.js

[gziolo]

There should be no textdomain used for translations expected to land in core.

[michalczaplinski]

Thanks! I removed it for both the pattern and post-meta sources in c9a245e

[artemiomorales]

Pending passing tests, looks good to me!

[SantosGuillamot]

I've tested it, and everything seems to keep working fine 🙂

[cbravobernal]

If you are backporting this file, make sure that multilines comments are with /* */

[michalczaplinski]

Thanks Carlos! The backport is here btw WordPress/wordpress-develop#5888 if you ever want to have a look.

[getdave]

I noticed this PR was merged after I raised the PHP Sync Tracking Issue for WP 6.5 and has changed PHP files that may need backporting to WP Core.

Please forgive the ping, but I marked as Needs PHP backport and also added to the tracking Issue.

[michalczaplinski]

@getdave Backported to Core in WordPress/wordpress-develop#5888