Scripts: Add viewScriptModule block.json support#58203
Merged
Conversation
sirreal
requested review from
ajitbohra,
gziolo,
nerrad,
ntwb and
ryanwelcher
as code owners
|
Size Change: 0 B Total Size: 1.69 MB ℹ️ View Unchanged
|
sirreal
changed the title
sirreal
added
[Type] Enhancement
|
Flaky tests detected in 0d5f4d1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7816713470
|
luisherranz
approved these changes
Feb 7, 2024
sirreal
force-pushed
the
add/scripts-view-script-module-support
branch
from
7f4c75d to
0d5f4d1
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNCore Committers: Use this line as a base for the props when committing in SVN: GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Support
viewScriptModulefor building view script modules.viewModuleis still supported but has been deprecated.Why?
The Module API was changed to use naming like "script module" instead of "module" so we're following that pattern with
viewScriptModule.See WordPress/wordpress-develop#5860
How?
Support is added just like
viewModulewas in #57461.Testing Instructions
Testing instructions are just like #57461, but make sure you switch
viewModuletoviewScriptModule.