Shadows: Prevent empty style object when removing shadow#58155
Merged
aaronrobertshaw merged 1 commit intotrunkfrom Jan 24, 2024
Merged
Shadows: Prevent empty style object when removing shadow#58155aaronrobertshaw merged 1 commit intotrunkfrom
aaronrobertshaw merged 1 commit intotrunkfrom
Conversation
aaronrobertshaw
added
the
[Type] Code Quality
aaronrobertshaw
requested review from
andrewserong,
madhusudhand and
vcanales
2 tasks
vcanales
approved these changes
Jan 24, 2024
Member
vcanales
left a comment
vcanales
left a comment
There was a problem hiding this comment.
Thanks! This tests well for me
|
Size Change: -24 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
aaronrobertshaw
deleted the
fix/shadow-support-leaving-empty-style-object
branch
Contributor
|
Too quick! Thanks for tidying this up @aaronrobertshaw 🎉 and nice work landing the other changes @vcanales! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Why?
Consistency with other supports and a tiny reduction of fluff in the block markup.
How?
cleanEmptyObjectto prevent saving an emptystyleobjectTesting Instructions
Screenshots or screencast