Add image block support for pattern overrides#57909
Merged
Conversation
talldan
added
[Type] Enhancement
49 tasks
|
Size Change: +25 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
kevin940726
approved these changes
Jan 17, 2024
Member
kevin940726
left a comment
kevin940726
left a comment
There was a problem hiding this comment.
LGTM 👍 . The title attribute doesn't work as mentioned in the description but could be a follow-up!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
See #53705
Similar to #57789
Adds image block support for pattern overrides.
Initial support is for the image src (URL attribute), the title and the alt text.
Unfortunately there doesn't seem to be a way to edit the
titleincontentOnlymode, and the value set in the media library isn't used by the block. It could be a bug to fix, or alternatively it might not be worth supporting title initially. 🤔I also think support could expand to caption, href, rel and linkTarget, similar to what was discussed for the button block. This would be best achieved in a follow-up that covers adding support in the block bindings API.
How?
Adds the configuration to support the image block.
Testing Instructions
Screenshots or screencast
(sorry for the poorly cropped video!)
Kapture.2024-01-17.at.15.34.52.mp4