Use slug instead of id for Font Collection#57735
Merged
matiasbenedetto merged 6 commits intotrunkfrom Jan 11, 2024
Merged
Conversation
pbking
added
[Feature] Typography
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/experimental/fonts/font-library/class-wp-font-collection.php ❔ lib/experimental/fonts/font-library/class-wp-font-library.php ❔ lib/experimental/fonts/font-library/class-wp-rest-font-collections-controller.php ❔ lib/experimental/fonts/font-library/font-library.php ❔ phpunit/tests/fonts/font-library/wpFontCollection/__construct.php ❔ phpunit/tests/fonts/font-library/wpFontCollection/getConfig.php ❔ phpunit/tests/fonts/font-library/wpFontCollection/getConfigAndData.php ❔ phpunit/tests/fonts/font-library/wpFontLibrary/getFontCollection.php ❔ phpunit/tests/fonts/font-library/wpFontLibrary/getFontCollections.php ❔ phpunit/tests/fonts/font-library/wpFontLibrary/registerFontCollection.php ❔ phpunit/tests/fonts/font-library/wpFontLibrary/unregisterFontCollection.php ❔ phpunit/tests/fonts/font-library/wpRestFontCollectionsController/getFontCollection.php ❔ phpunit/tests/fonts/font-library/wpRestFontCollectionsController/getFontCollections.php ❔ phpunit/tests/fonts/font-library/wpRestFontCollectionsController/registerRoutes.php |
matiasbenedetto
requested changes
Jan 10, 2024
Contributor
matiasbenedetto
left a comment
matiasbenedetto
left a comment
There was a problem hiding this comment.
I think there was a mistake while committing to this branch because the changes don't match the PR title and description.
pbking
force-pushed
the
try/use-slug-instead-of-id-for-font-collection
branch
from
d4c6df4 to
0094034
Compare
Contributor
Author
|
Sorry @matiasbenedetto I'm not sure what happend with the work. I force-pushed and the changes are here now. |
matiasbenedetto
approved these changes
Jan 11, 2024
matiasbenedetto
deleted the
try/use-slug-instead-of-id-for-font-collection
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This removes the
idproperty from the Font Collection object and usessluginstead.Why?
The value is treated like a slug, but with the wrong name. This just changes what we call it.
Fixes: (?)
How?
By changing the
Font Collectionclass, the rest controller, the default collection and all related unit tests.Testing Instructions
The unit tests should all pass.
The "default" (Google Fonts) collection should still be available to the user.
NOTE: These changes are dependent on #57734 being merged first; those changes are already incorporated into these.