DataViews: add new page button in Pages#57685
Merged
Conversation
oandregal
requested review from
jameskoster,
jorgefilipecosta,
ntsekouras and
youknowriad
oandregal
added
[Type] Experimental
|
Size Change: +99 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
jameskoster
approved these changes
Jan 9, 2024
Contributor
jameskoster
left a comment
jameskoster
left a comment
There was a problem hiding this comment.
Seems to be working well, and is consistent with the current flow where the user is dropped in the Editor immediately after the page is drafted.
We may want to revisit that in the future, and give users to option to go and edit the page, or stay in the pages data view, but that can come later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #55083
Follow-up to #57578
What?
Implements a new button for adding a page from Pages.
Why?
We want to have parity with the existing Pages, which let users create a page from there.
How?
Adds a new button in the content frame, like the one in Templates.
Alternatively, it could have been added in the sidebar as a
+icon next to the title, like the existing Pages with the experiment disabled – though the button in the content frame is preferred as of this conversation.Testing Instructions