Editor: Unify the Editor Mode preference.#57642
Merged
youknowriad merged 3 commits intotrunkfrom Jan 12, 2024
Merged
Conversation
youknowriad
added
[Type] Enhancement
youknowriad
requested review from
gziolo and
talldan
and removed request for
a team
24 tasks
|
Size Change: +3.82 kB (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
t-hamano
reviewed
Jan 8, 2024
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
Do we also need to update legacy storage data migration?
Contributor
Author
No, because I believe the editor migration is applied on top of this one (as seen in the unit tests) |
t-hamano
approved these changes
Jan 9, 2024
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
Do we also need to update legacy storage data migration?
No, because I believe the editor migration is applied on top of this one (as seen in the unit tests)
I see, I think there's no problem in that case 👍
aaronrobertshaw
approved these changes
Jan 9, 2024
Contributor
aaronrobertshaw
left a comment
aaronrobertshaw
left a comment
There was a problem hiding this comment.
Late to the party but this LGTM 👍
Unit tests are passing and it manually tests well across the site and post editors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #52632
Similar to #57468
What?
This PR continues the work on the great unification between post and site editors. In this PR we're unifying the "editor mode" preference. If the user enables the code editor in the post editor, the setting should be used in the site editor as well.