Editor: Unify the distraction free preference#57590
Merged
youknowriad merged 1 commit intotrunkfrom Jan 5, 2024
Merged
Conversation
youknowriad
added
[Type] Enhancement
|
Size Change: -65 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
24 tasks
jeryj
approved these changes
Jan 5, 2024
Contributor
jeryj
left a comment
jeryj
left a comment
There was a problem hiding this comment.
Tests well. I can toggle Distraction free in the site editor/post editor and the setting is matched when reloading the other. Just had a question about the useMemo being removed.
| setPreference( 'core', 'distractionFree', false ); | ||
| }; | ||
|
|
||
| const sections = useMemo( () => [ |
Contributor
Author
There was a problem hiding this comment.
Because it was useless (it had no dependencies) so it's like there's no useMemo to start with.
| postWithTemplate: _context?.postId, | ||
| }; | ||
| }, | ||
| [ isLargeViewport ] |
Contributor
There was a problem hiding this comment.
Looks like this was only used for the top toolbar setting, which got moved to core by #57531. Good catch on removing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #52632
Similar to #57468
What?
This PR continues the work on the great unification between post and site editors. In this PR we're unifying the "Distraction free mode" preference. If the user enables it in the post editor, the setting should be used in the site editor as well.
Testing instructions