[Pattern overrides] Allow multiple attributes overrides#57573
Merged
kevin940726 merged 1 commit intotrunkfrom Jan 9, 2024
Merged
[Pattern overrides] Allow multiple attributes overrides#57573kevin940726 merged 1 commit intotrunkfrom
kevin940726 merged 1 commit intotrunkfrom
Conversation
kevin940726
added
[Type] Experimental
kevin940726
requested review from
aaronrobertshaw,
artemiomorales,
glendaviesnz and
talldan
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/experimental/blocks.php ❔ lib/experimental/connection-sources/index.php |
|
Size Change: +49 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
glendaviesnz
approved these changes
Jan 7, 2024
Contributor
glendaviesnz
left a comment
glendaviesnz
left a comment
There was a problem hiding this comment.
Tested well for me, I was able to:
✅ Set pattern overrides checkbox for paragraph blocks in synced pattern
✅ Edit instances of those paragraphs when pattern inserted in a post
✅ See the custom instance content when post viewed in frontend
Contributor
|
Was this backported to Core already? |
Contributor
@youknowriad this was pulled into the work that the block bindings team did to set up the new |
youknowriad
added
Backported to WP Core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of #53705. Based on #56235.
Allow multiple attributes for a given block (`core/image' for instance).
Why?
As requested in #57249 (comment).
How?
Store
overridesas an object for each id.There might be some manual updates needed in the backend in #57249 to support this.
Testing Instructions
Pattern overrides should still work.
Save the (partially) synced pattern.
Screenshots or screencast
N/A