Editor: Unify spotlight mode preference#57533
Merged
youknowriad merged 3 commits intotrunkfrom Jan 4, 2024
Merged
Conversation
youknowriad
added
[Type] Enhancement
24 tasks
|
Size Change: -47 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
Jan 4, 2024
Member
Mamaduka
left a comment
Mamaduka
left a comment
There was a problem hiding this comment.
Thank you, @youknowriad!
Besides one note for the Site Editor, the changes test well for me.
✅ The preference is correctly migrated.
✅ The preference is shared between editors.
❌ The site editor is displaying in spotlight mode when canvas mode is view.
|
|
||
| richEditingEnabled: true, | ||
| supportsTemplateMode: true, | ||
| focusMode: canvasMode === 'view' && focusMode ? false : focusMode, |
Member
There was a problem hiding this comment.
This is a breaking change; the spotlight mode will now apply in view mode.
Contributor
Author
There was a problem hiding this comment.
I can restore it but I don't like that part :P
Member
There was a problem hiding this comment.
I think the current behavior creates bad UX when exploring theme styles.
Update: Actually, the behavior is the same on the trunk when browsing styles from the sidebar; this might be something we'll need to fix separately.
The 2da2fd6 fixed regression for view mode.
Screenshot
CleanShot.2024-01-04.at.12.03.50.mp4
packages/preferences-persistence/src/migrations/legacy-local-storage-data/test/index.js
Show resolved
Hide resolved
ntsekouras
reviewed
Jan 4, 2024
packages/edit-site/src/components/block-editor/use-site-editor-settings.js
Show resolved
Hide resolved
Mamaduka
approved these changes
Jan 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #52632
Similar to #57468
What?
This PR continues the work on the great unification between post and site editors. In this PR we're unifying the "Spotlight mode" preference. If the user enables it in the post editor, the setting should be used in the site editor as well.
Testing instructions