Editor: Unify context text cursor preference#57479
Merged
youknowriad merged 1 commit intotrunkfrom Jan 3, 2024
Merged
Conversation
youknowriad
added
[Type] Enhancement
youknowriad
requested review from
adamziel and
cbravobernal
and removed request for
a team
24 tasks
|
Size Change: +7 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
Jan 2, 2024
Contributor
ntsekouras
left a comment
ntsekouras
left a comment
There was a problem hiding this comment.
Code wise this looks good. I think we should settle though on the used scope first - whether use edit-post or something related to the editor package.
scruffian
reviewed
Jan 2, 2024
Contributor
scruffian
left a comment
scruffian
left a comment
There was a problem hiding this comment.
In my testing, if I have this setting turned on in either editor, and off it the other, this change enables it in both. I think this is probably the best way to handle this scenario, but just wanted to raise it.
youknowriad
force-pushed
the
unify/context-text-preference
branch
2 times, most recently
from
b0dc541 to
b4922c4
Compare
Contributor
Author
|
This has been rebased and includes the migration. |
talldan
approved these changes
Jan 3, 2024
youknowriad
force-pushed
the
unify/context-text-preference
branch
from
b4922c4 to
70550fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #52632
Similar to #57468
What?
This PR continues the work on the great unification between post and site editors. In this PR we're unifying the "contain text cursor inside block" preference. If the user enables it in the post editor, the setting should be used in the site editor as well.
Testing instructions