Background image block support: Add tests for size and repeat output#57474
Merged
andrewserong merged 1 commit intotrunkfrom Jan 2, 2024
Merged
Background image block support: Add tests for size and repeat output#57474andrewserong merged 1 commit intotrunkfrom
andrewserong merged 1 commit intotrunkfrom
Conversation
andrewserong
added
[Type] Code Quality
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ phpunit/block-supports/background-test.php ❔ phpunit/style-engine/style-engine-test.php |
|
Size Change: 0 B Total Size: 1.69 MB ℹ️ View Unchanged
|
ramonjd
approved these changes
Jan 2, 2024
Member
ramonjd
left a comment
ramonjd
left a comment
There was a problem hiding this comment.
Thanks for the test coverage. 👍🏻 All are passing for me.
71 tasks
youknowriad
added
Backported to WP Core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of: #54336, follow-up to #57005
Add tests for newly added background size and repeat features.
Why?
Ensure these features have coverage to prevent regressions.
How?
centerposition whencontainis set as the background size)backgroundSizeand fallbackbackgroundPositionvalues are coveredTesting Instructions
Run the tests (or just check that the Github Actions pass):