Don't change error handling in WP_Theme_JSON_Gutenberg::set_spacing_sizes()

[anton-vlasenko]

What?

#55313 changed error handling in WP_Theme_JSON_Gutenberg::set_spacing_sizes(). Since changes from WP_Theme_JSON_Gutenberg will eventually be merged into Core, it's important to maintain parity between both codebases.

Why?

_doing_it_wrong() is not a direct replacement for trigger_error(), since _doing_it_wrong() only triggers a PHP error if WP_DEBUG is enabled.

How?

This PR reverts the changes introduced in #55313 while maintaining PHPUnit 10 compatibility.

Testing Instructions

1. Make sure that the WP_Theme_JSON_Gutenberg_Test tests pass.

Testing Instructions for Keyboard

Screenshots or screencast

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ lib/class-wp-theme-json-gutenberg.php
❔ phpunit/class-wp-theme-json-test.php

[jorgefilipecosta]

The changes look good to me 👍

[anton-vlasenko]

Thank you for the review and approval, @jorgefilipecosta! I apreciate it.

[anton-vlasenko]

Trac Ticket: https://core.trac.wordpress.org/ticket/60305
Backport PR: WordPress/wordpress-develop#5911

[getdave]

Thank you for working on this @anton-vlasenko 👍

FYI I updated the PHP Sync Tracking Issue to:

• add the Trac link
• add the Core PR backport link
• remove the completion checkmark as this has yet to be merged into Core

Please could I ask you to check back on the Tracing Issue when the Core PR is merged and mark the line item as complete? This will help us keep track of what's outstanding. Very much appreciated 🙏

[anton-vlasenko]

@getdave, the PR has been merged, and I've marked it as complete in the PHP Sync Tracking issue. Thank you.

[getdave]

Thank you Anton 🙇