Conversation
…und (#55285) * Use text color at different opacities for track and indicator * Add high contrast mode styles * CHANGELOG # Conflicts: # packages/components/CHANGELOG.md
mikachan
added
the
[Type] WP Core Ticket
|
Size Change: +176 B (0%) Total Size: 1.63 MB
ℹ️ View Unchanged
|
* Remove empty attrs. * Fix linter errors --------- Co-authored-by: Sarah Norris <sarah@sekai.co.uk>
…errides are rendered (#55288) * useBlockPreview: Try alternative fix for displaying local style overrides * Avoid duplicate styles, fix rendering issues in Safari * Add more explanatory comments * Remove additional check for styles within the block preview, as it is not needed since EditorStyles handles its own style overrides retrieval
|
Flaky tests detected in ab7369e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6535444485
|
* Fix PHP notice when an image with lightbox is deleted * Fix PHP notice when an image with lightbox is deleted
SiobhyB
approved these changes
Oct 16, 2023
Contributor
SiobhyB
left a comment
SiobhyB
left a comment
There was a problem hiding this comment.
LGTM!
Noting for posterity that we discussed the failing tests in Slack's #core-editor channel. We can't reproduce them locally and believe they're false positives. As such, we're choosing to proceed with the changes from this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest commits for WordPress 6.4 RC1.