Block Supports: Backport optimization from Core for Elements Support#55228
Merged
Block Supports: Backport optimization from Core for Elements Support#55228
Conversation
dmsnell
added
the
Backport from WordPress Core
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/block-supports/elements.php |
tellthemachines
approved these changes
Oct 11, 2023
Contributor
tellthemachines
left a comment
tellthemachines
left a comment
There was a problem hiding this comment.
Thanks for following up with this! Code changes look good and element supports are working as expected (tested by adding link/heading colors to a few blocks).
e2e failures seem unrelated and pass locally for me.
Brings over optimization surfaced during the WordPress 6.4 beta release for block supports elements, which entails skipping needless iteration when it's known that the iteration need not continue. See WordPress/wordpress-develop#5411 See [#59544-trac](https://core.trac.wordpress.org/ticket/59544)
dmsnell
force-pushed
the
block-supports/backport-optimization-from-core
branch
from
bf07cc1 to
7602b56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Brings over optimization surfaced during the WordPress 6.4 beta release for block supports elements, which entails skipping needless iteration when it's known that the iteration need not continue.
See WordPress/wordpress-develop#5411
See #59544-trac
Why?
Keeps versions in sync. This optimization was performed in Core first in order to quickly address one of a number of performance issues that were raised during testing the beta release of WordPress 6.4. Its fix should also come back to Gutenberg, since that file is normally updated through the package update.
How?
Copies code from Core into Gutenberg in the corresponding file.
Testing Instructions
Verify that the backport is appropriately applied and that all tests pass.