[Incomplete] Add icons for popular podcast services#54556
Closed
properlypurple wants to merge 3 commits intoWordPress:trunkfrom
properlypurple:trunk
Closed
[Incomplete] Add icons for popular podcast services#54556properlypurple wants to merge 3 commits intoWordPress:trunkfrom properlypurple:trunk
properlypurple wants to merge 3 commits intoWordPress:trunkfrom
properlypurple:trunk
Conversation
|
Warning: Type of PR label error To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. |
Contributor
Author
|
Closing because this is likely going to be redundant with #30749 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR aims to add icons for some popular podcast services to the social icons block.
Why?
The social icons block doesn't have icons for some popular podcasting services, and doesn't have a straightforward way to add custom icons. This PR fixes #36755
How?
I aim to add the following icons
I have only added Google and Pocketcasts for now. There are significant differences in the brand guidelines for these services, and this will likely need design feedback before going any further. For reference
Testing Instructions
Testing Instructions for Keyboard
This doesn't change existing interactions for the social icons block, so the usual steps for this block apply.
Screenshots or screencast