Skip to content

Review all the 'Add New' strings #53984#54132

Closed
jamestitus299 wants to merge 23 commits intoWordPress:trunkfrom
jamestitus299:trunk
Closed

Review all the 'Add New' strings #53984#54132
jamestitus299 wants to merge 23 commits intoWordPress:trunkfrom
jamestitus299:trunk

Conversation

@jamestitus299
Copy link
Copy Markdown

@jamestitus299 jamestitus299 commented Sep 3, 2023

What?

Review all the 'Add New' strings #53984
Changed the inconsistent "add new " to "Add New ..."

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Sep 3, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 3, 2023

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @jamestitus299! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

alexstine
alexstine reviewed Sep 3, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@alexstine alexstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamestitus299 Thanks for the PR. 👍 Suggested changes below.

package-lock.json
Copy link
Copy Markdown
Contributor

@alexstine alexstine Sep 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove changes to this file. These should not be necessary.

package.json
Copy link
Copy Markdown
Contributor

@alexstine alexstine Sep 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove changes to this file. These should not be necessary.

packages/editor/src/components/post-taxonomies/test/index.js Outdated
},
labels: {
add_new_item: 'Add new genre',
add_new_item: 'Add New genre',
Copy link
Copy Markdown
Contributor

@alexstine alexstine Sep 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
add_new_item: 'Add New genre',
add_new_item: 'Add New Genre',

packages/editor/src/components/post-taxonomies/test/index.js Outdated
},
labels: {
add_new_item: 'Add new category',
add_new_item: 'Add New category',
Copy link
Copy Markdown
Contributor

@alexstine alexstine Sep 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
add_new_item: 'Add New category',
add_new_item: 'Add New Category',

packages/editor/src/components/post-taxonomies/test/index.js Outdated
).not.toBeInTheDocument();
expect(
screen.getByRole( 'button', { name: 'Add new genre' } )
screen.getByRole( 'button', { name: 'Add New genre' } )
Copy link
Copy Markdown
Contributor

@alexstine alexstine Sep 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
screen.getByRole( 'button', { name: 'Add New genre' } )
screen.getByRole( 'button', { name: 'Add New Genre' } )

packages/editor/src/components/post-taxonomies/test/index.js Outdated
).toBeVisible();
expect(
screen.queryByRole( 'button', { name: 'Add new category' } )
screen.queryByRole( 'button', { name: 'Add New category' } )
Copy link
Copy Markdown
Contributor

@alexstine alexstine Sep 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
screen.queryByRole( 'button', { name: 'Add New category' } )
screen.queryByRole( 'button', { name: 'Add New Category' } )

packages/editor/src/components/post-taxonomies/test/index.js Outdated
).toBeVisible();
expect(
screen.getByRole( 'button', { name: 'Add new genre' } )
screen.getByRole( 'button', { name: 'Add New genre' } )
Copy link
Copy Markdown
Contributor

@alexstine alexstine Sep 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
screen.getByRole( 'button', { name: 'Add New genre' } )
screen.getByRole( 'button', { name: 'Add New Genre' } )

packages/editor/src/components/post-taxonomies/test/index.js Outdated
).toBeVisible();
expect(
screen.getByRole( 'button', { name: 'Add new category' } )
screen.getByRole( 'button', { name: 'Add New category' } )
Copy link
Copy Markdown
Contributor

@alexstine alexstine Sep 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
screen.getByRole( 'button', { name: 'Add New category' } )
screen.getByRole( 'button', { name: 'Add New Category' } )

packages/editor/src/components/post-taxonomies/test/index.js Outdated
expect( screen.getByRole( 'group', { name: 'Genres' } ) ).toBeVisible();
expect(
screen.getByRole( 'button', { name: 'Add new genre' } )
screen.getByRole( 'button', { name: 'Add New genre' } )
Copy link
Copy Markdown
Contributor

@alexstine alexstine Sep 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
screen.getByRole( 'button', { name: 'Add New genre' } )
screen.getByRole( 'button', { name: 'Add New Genre' } )

packages/editor/src/components/post-taxonomies/test/index.js Outdated
).not.toBeInTheDocument();
expect(
screen.queryByRole( 'button', { name: 'Add new genre' } )
screen.queryByRole( 'button', { name: 'Add New genre' } )
Copy link
Copy Markdown
Contributor

@alexstine alexstine Sep 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
screen.queryByRole( 'button', { name: 'Add New genre' } )
screen.queryByRole( 'button', { name: 'Add New Genre' } )

@alexstine alexstine added [Type] Bug An existing feature does not function as intended [Package] Editor /packages/editor labels Sep 3, 2023
@jamestitus299
updated Review all the 'Add New' strings
2597b4c
@jamestitus299
Merge branch 'WordPress:trunk' into trunk
d58861a
@jamestitus299
Merge branch 'WordPress:trunk' into devjam
9cafa6b
@jamestitus299
Merge pull request #2 from jamestitus299/devjam
e0213ba 
Devjam
@jamestitus299
restored package.json
49fa239
@jamestitus299
restored changes
4d76781
@jamestitus299
Revert "Add missing dependency of @wordpress/patterns on `@babel/ru…
768a0b8 
…ntime` (WordPress#54118)"

This reverts commit 3b114f7.

restore changes
@jamestitus299
changes restored
aa99314
@jamestitus299
Merge remote-tracking branch 'refs/remotes/origin/devjam' into devjam
523bf03 
changes
@jamestitus299
Merge pull request #3 from jamestitus299/devjam
cc87e7f 
Devjam
@jamestitus299
restored changes
c8db2b5
@jamestitus299
Merge pull request #4 from jamestitus299/devjam
9498666 
restored changes
@jamestitus299
changes restored
0d09f98
@jamestitus299
Merge branch 'WordPress:trunk' into trunk
46aa619
@jamestitus299
Merge branch 'WordPress:trunk' into devjam
ca42291
@jamestitus299
Merge branch 'devjam' of https://github.com/jamestitus299/gutenberg i…
7be232e 
…nto devjam

updated
@jamestitus299
Merge pull request #5 from jamestitus299/devjam
ed5bf37 
Devjam
@jamestitus299
Merge branch 'WordPress:trunk' into trunk
9aab13e
@jamestitus299
Merge branch 'WordPress:trunk' into trunk
88ae163
@joedolson joedolson closed this Sep 5, 2023
@joedolson joedolson reopened this Sep 5, 2023
@joedolson
Copy link
Copy Markdown
Contributor

joedolson commented Sep 5, 2023

Sorry; closed the wrong PR! Too many related things open...

t-hamano
t-hamano reviewed Sep 19, 2023
View reviewed changes
package.json
"welcome-build-command": "npm run dev"
}
}
} No newline at end of file
Copy link
Copy Markdown
Contributor

@t-hamano t-hamano Sep 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change shouldn't affect anything, but I think it's a good idea to revert unnecessary changes.

@Mamaduka
Copy link
Copy Markdown
Member

Mamaduka commented Aug 4, 2025

Thanks for contributing, @jamestitus299!

It looks like the patch needs refreshing. Do you have time to follow up on this?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 4, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jamestitus299 <jamestitus299@git.wordpress.org>
Co-authored-by: alexstine <alexstine@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: joedolson <joedolson@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: lalitkumawat1m <lalitkumawat@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@jamestitus299
Copy link
Copy Markdown
Author

jamestitus299 commented Aug 6, 2025

@Mamaduka I don't think I can help right now. Sorry.

@lalitkumawat1m
Copy link
Copy Markdown
Contributor

lalitkumawat1m commented Aug 6, 2025

Is this issue still open or valid?

@Mamaduka Mamaduka mentioned this pull request Aug 6, 2025
Closed
@Mamaduka
Copy link
Copy Markdown
Member

Mamaduka commented Aug 6, 2025

Thanks for the update, @jamestitus299!

It looks like @lalitkumawat1m is interested in working on this issue, so I'm going to close this PR.

@Mamaduka Mamaduka closed this Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexstine alexstine alexstine left review comments

@t-hamano t-hamano t-hamano left review comments

Assignees

No one assigned

Labels

First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Editor /packages/editor [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jamestitus299 @joedolson @Mamaduka @lalitkumawat1m @alexstine @t-hamano