Tweak, and add, more consistent commands#53496
Merged
Conversation
richtabor
added
[Type] Enhancement
|
Size Change: +1.38 kB (0%) Total Size: 1.5 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Aug 10, 2023
youknowriad
approved these changes
Aug 10, 2023
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
Left a small comment otherwise, this LGTM
richtabor
force-pushed
the
try/clean-up-commands
branch
from
9f3de64 to
afe81c6
Compare
youknowriad
reviewed
Aug 10, 2023
packages/edit-site/src/hooks/commands/use-edit-mode-commands.js
Outdated
Show resolved
Hide resolved
|
Flaky tests detected in afe81c6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5825553707
|
Co-authored-by: Riad Benguella <benguella@gmail.com>
SiobhyB
added
the
[Feature] Code Editor
Contributor
|
It looks like this PR introduced a duplicate Patterns command. One already existed called "Open patterns" and took into account whether or not the active theme could access the site editor. See #52817 for the PR introducing the original command. 
|
Contributor
|
The duplicate patterns commands have been consolidated in #54133. |
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Why?
Trying to establish consistency with command language, style, and actions.
Testing Instructions
Testing Instructions for Keyboard
Visuals
Before
After