Don't allow access to Styles-related pages via the command palette in the hybrid theme#53123
Merged
Don't allow access to Styles-related pages via the command palette in the hybrid theme#53123
Conversation
|
Size Change: +80 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 9b15f6c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5694020446
|
t-hamano
added
[Package] Core commands
[Type] Bug
t-hamano
changed the title
Contributor
Author
|
I have discovered that relying on the current Update: Based on this comment, it appears that this problem can be solved by using |
t-hamano
force-pushed
the
fix/style-page-hybrid
branch
from
9b15f6c to
ebf53bc
Compare
Contributor
|
Do you have an example of a hybrid theme? |
youknowriad
approved these changes
Aug 7, 2023
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
LGTM 👍
I didn't test the "hybrid theme" case though.
Contributor
Author
|
Thanks for the review! I think you can access |
Contributor
Author
|
As far as I have tested, it is working as expected in the hybrid theme, so I would like to merge it 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #52154
What?
This PR prevents two style-related pages from being accessible via the command palette in a classic theme that supports
block-template-parts.As a result, unintended page transitions and canvas rendering in the site editor will be fixed.
f0c768dd61ba4a8ca41e082ca1e2e73a.mp4
Why?
At least at this time, global styles are not available for non-block themes. However, my understanding is that useCommonCommands is also executed when a non-block theme accesses the template parts page. This results in two unintended commands being registered by useCommand.
How?
I started by splitting the
useIsSiteEditorAccessible()hook introduced in #52987 into the following two hooks:useIsTemplatesAccessible()useIsBlockBasedTheme()And to conditionally execute the command, I used
useCommandLoader()instead ofuseCommand(). In addition, use the newly addeduseIsBlockBasedTheme()hook and change these two commands to do nothing if it is not a block theme.Testing Instructions
In the classic theme (TT1), the hybrid theme (EmptyHybrid) and the block theme (TT3), confirm that all commands affected by this PR work as expected.
Classic Theme
Hybrid Theme
Block Theme
Next Step
I have further confirmed that the page menu in the Site Editor is also unintentionally accessible. This will be addressed in a future PR.