[RNMobile] Remove non-functioning caption button from mobile block toolbar#53010
Merged
derekblank merged 3 commits intotrunkfrom Jul 27, 2023
Merged
Conversation
derekblank
added
the
[Type] Bug
|
Size Change: 0 B Total Size: 1.44 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 9cb0630. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5677744257
|
dcalhoun
added
Mobile App - i.e. Android or iOS
dcalhoun
approved these changes
Jul 27, 2023
Member
dcalhoun
left a comment
dcalhoun
left a comment
There was a problem hiding this comment.
Thanks for addressing this so quickly. 🎉
I verified the changes function as expected in both the mobile and web editors, using an iPhone 14 Pro simulator and macOS Safari respectively.
I also added a few additional labels to this PR to communicate intent and linked it to #52977 so that the bug report is automatically closed when this PR is merged.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Removes a non-functioning caption button from the mobile Gallery block toolbar. On mobile, the caption can be edited directly via the text input beneath the gallery item, and the caption button is not utilized in the same way it is on web.
Why?
A button that is used to add/remove gallery captions on the web is now present in the mobile gallery toolbar after recent Editor UX changes. This is very similar to the MediaReplaceFlow component being removed from the toolbar for mobile.
This change removes (or hides) a non-functioning button on mobile as further discussion on the button's behavior continues: #52977 (comment)
How?
Moves the web's caption button into a
Platform.isWebboolean block.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast