Fixed Docker Image Size Ballooning#51034
Merged
ObliviousHarmony merged 2 commits intotrunkfrom May 30, 2023
Merged
Conversation
When running `useradd` without the `-l` option it can cause certain log files to reach absurd file sizes. This option avoids writing anything to these logs/
Contributor
Author
|
I haven't encountered this problem locally, so, I can't personally confirm whether or not this fix works. In theory it should, based on the research @horsemanV did. If possible, would you mind checking out this branch and seeing if it solves your problem @horsemanV? |
|
Size Change: +1.25 kB (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 8a8e02e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5100273374
|
alexstine
approved these changes
May 29, 2023
Contributor
alexstine
left a comment
alexstine
left a comment
There was a problem hiding this comment.
This change makes sense to me.
noahtallen
approved these changes
May 30, 2023
Member
noahtallen
left a comment
noahtallen
left a comment
There was a problem hiding this comment.
Does -o cover all the cases we were using || true for? This looks good and tests well!
Contributor
Author
Yeah, we were only using |
|
@ObliviousHarmony it turns out my GitHub notifications I've just finished testing locally and can verify that yes, this PR does fix the issues. Attached is a screenshot of the new image sizes. While testing I did run into another issue (also seemingly related to users/groups in the Docker images), I'll check for it in open issues and write it up if it's not already reported elsewhere. Thanks again. |
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
When running `useradd` without the `-l` option it can cause certain log files to reach absurd file sizes. This option avoids writing anything to these logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This pull request stops the
wordpressDocker image generated bywp-env startfrom reaching absurd file sizes.Why?
When ran without the
-loption,useraddcan cause certain log files the balloon in size. This seems to have something to do with how high theuidis, but, the option should eliminate the problem.Closes #50934.
How?
We add the
-loption touseraddin thewordpressDockerfile.Testing Instructions
npx wp-env destroy.npx wp-env start.