[RNMobile] Upgrade compile and target sdk version to Android API 33#50731
Merged
[RNMobile] Upgrade compile and target sdk version to Android API 33#50731
Conversation
fluiddot
added
the
Mobile App - i.e. Android or iOS
fluiddot
added
the
Mobile App - Automation
This was referenced May 18, 2023
Upgrade compile and target sdk version to Android API 33
wordpress-mobile/react-native-reanimated#24
Merged
Merged
Closed
fluiddot
commented
May 19, 2023
packages/react-native-bridge/android/react-native-bridge/build.gradle
Outdated
Show resolved
Hide resolved
|
Size Change: 0 B Total Size: 1.39 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 42f9d79. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5133957623
|
fluiddot
force-pushed
the
rnmobile/update/upgrade-android-13
branch
from
164ff34 to
3585191
Compare
fluiddot
commented
May 19, 2023
| createGestureHandler: jest.fn(), | ||
| dropGestureHandler: jest.fn(), | ||
| updateGestureHandler: jest.fn(), | ||
| jest.mock( 'react-native', () => { |
Contributor
Author
There was a problem hiding this comment.
I noticed when mocking the WebView native module that in some tests the mock was restored, leading to failures.
Mocking the native modules this way should prevent this issue.
50 tasks
fluiddot
force-pushed
the
rnmobile/update/upgrade-android-13
branch
from
249529d to
e25da81
Compare
…e-bridge` This version matches with the one set in `react-native-editor`.
This is needed to fetch the RN library dependencies that use sdk version 33.
Update Podfile.lock
fluiddot
force-pushed
the
rnmobile/update/upgrade-android-13
branch
from
b04c36c to
5b00dd9
Compare
fluiddot
commented
May 29, 2023
geriux
approved these changes
May 31, 2023
Member
geriux
left a comment
geriux
left a comment
There was a problem hiding this comment.
LGTM! CI checks are passing and manual testing was done using the main apps, nice work! 🚀
Member
|
What do you think about adding an internal note of the changes? |
Contributor
Author
@geriux Sure, I'll add an internal note about this in |
2 tasks
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…ordPress#50731) * Bump sdk version to 33 * Bump `buildToolsVersion` to match RN versions * Bump `kotlinVersion` version to match WPAndroid version * Bump Aztec version to 1.6.4 * Update react-native-editor deps * Bump `kotlinVersion` version of `react-native-aztec` and `react-native-bridge` This version matches with the one set in `react-native-editor`. * Bump RN libraries publisher version to v2 This is needed to fetch the RN library dependencies that use sdk version 33. * Bump `react-native-webview` to version `11.26.1` * Mock React Native modules including WebView module * Update react-native-editor deps with `wp-fork` tags * Update Podfile.lock Update Podfile.lock * Update `react-native-slider` dependency * Update `react-native-editor` changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to wordpress-mobile/gutenberg-mobile#5556.
Related PRs:
What?
Upgrade
react-native-aztec,react-native-bridge, andreact-native-editorprojects to Android 13 (API 33). As well as the different React Native dependencies:react-native-libraries-publisherreact-native-gesture-handlerreact-native-linear-gradientreact-native-prompt-androidreact-native-reanimatedreact-native-sliderreact-native-videoWhy?
Google Play requires apps to update to Android 13 (API level 33) before August 31, 2023.
How?
compileSdkVersionandtargetSdkVersion.buildToolsVersionto match the React Native version (reference).kotlinVersionto match the WPAndroid version (reference).AztecEditor-Androidversion to the one that upgraded to Android 13 (reference).react-native-libraries-publisherreact-native-gesture-handlerreact-native-linear-gradientreact-native-prompt-androidreact-native-reanimatedreact-native-sliderreact-native-videoreact-native-hsv-color-picker(this library depends onreact-native-linear-gradient, so we need to update it too)react-native-webviewto version 11.26.1 (c45a12b)react-native-webview(aff6a53).Testing Instructions
This change doesn't affect a specific area, hence to test it we should basically smoke test the editor and check that works as expected.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A