Add: Story for the full global styles UI.#49031
Merged
jorgefilipecosta merged 1 commit intotrunkfrom Mar 24, 2023
Merged
Conversation
jorgefilipecosta
added
[Type] Enhancement
|
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
jorgefilipecosta
force-pushed
the
add/story-for-full-global-styles-UI
branch
from
15405d9 to
4daab94
Compare
|
Flaky tests detected in b3f7977. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4503515195
|
jorgefilipecosta
force-pushed
the
add/story-for-full-global-styles-UI
branch
from
4daab94 to
1e0f3fc
Compare
Member
|
👋 Heads up: We will be adding some additional config so we can better isolate stylesheet dependencies (#49099). If your PR merges first, could you let me know if this |
Contributor
|
#49099 just got merged, so there's likely a need to rebase and rewrite some config to make this PR work |
jorgefilipecosta
force-pushed
the
add/story-for-full-global-styles-UI
branch
from
1e0f3fc to
b3f7977
Compare
Member
Author
Thank you for the heads up. This PR was updated taking into account the latest changes. |
ciampo
approved these changes
Mar 23, 2023
Contributor
ciampo
left a comment
ciampo
left a comment
There was a problem hiding this comment.
The storybook config part looks good!
I trust that the Storybook example itself is working as expected at the moment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a story for the full global styles UI.
With the work starting at #49014 to move the styles editor to the browse mode sidebar, we need to make sure the global styles UI and the underlying components work well on a dark background.
There is a large amount of work required to make the components look good on dark background and it will require multiple interactions.
In order to make it possible to test the underlying global styles UI components in "dark mode", a story provides an easy UI to do it.
This PR adds a story for the entire global styles UI.
Sreenshot
Testing
Execute
npm run storybook:dev.Verify there is "Global Styles UI" story inside the edit site package in the story book.
Verify it is possible to use the component without any crashes.