Block Editor: Optimize __unstableGetVisibleBlocks()#47681
Merged
Conversation
tyxla
added
[Type] Performance
tyxla
requested review from
Mamaduka,
flootr,
jorgefilipecosta,
jsnajdr,
ntsekouras and
youknowriad
|
Size Change: +111 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 2f1aa42. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4074066683
|
ntsekouras
reviewed
Feb 2, 2023
ntsekouras
approved these changes
Feb 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR improves the performance of the
__unstableGetVisibleBlocksselector by changing it to work with an array instead ofSet. This allows us to avoid unnecessary extra updates when the parent component is re-rendered, but an update is triggered just because we always return anew Set().Why?
When typing into the main inserter we see a bunch of updates coming from that selector recalculating on every re-render. I didn't expect that to happen, since I was testing with an empty post that would have no hidden blocks.
I spotted this while working on #47679.
How?
We're doing a couple of optimizations:
Setto an array since there's no good reason to use aSetthere.I'd love to know if there was some additional purpose behind using a
Setfor the block visibility.Testing Instructions
Testing Instructions for Keyboard
None.
Screenshots or screencast
None.