Bring back the heading and the menu selector in the ellipsis menu#46622
Merged
draganescu merged 2 commits intotrunkfrom Dec 20, 2022
Merged
Bring back the heading and the menu selector in the ellipsis menu#46622draganescu merged 2 commits intotrunkfrom
draganescu merged 2 commits intotrunkfrom
Conversation
draganescu
added
[Type] Enhancement
|
Size Change: +103 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
Contributor
|
We also need to account for the case when there are no Navigation menus:
The code is so convoluted I wonder if we should fork on the experiment earlier... |
Contributor
Author
|
I thought we got rid of that ... @scruffian I've resorted in d975aa3 to keeping the create menu option in the dropdown instead of showing the button. I can't remember what the previous solution was ... but considering that edits to the default page list (customize or add a link) auto creates a menu, the crete menu shouldn't be as visible as a big button. |
draganescu
force-pushed
the
revert/46070
branch
from
3eecdc0 to
d975aa3
Compare
draganescu
force-pushed
the
revert/46070
branch
from
d975aa3 to
261d955
Compare
82 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Reverts #46070
Why?
Because the initial idea in #45555 is still valuable - to lower the prominence of a secondary /power user action: switching menus.
While #45555 tried to address the superfluous "menu" heading the solution is not to bring back the current selector.
How?
Revert the changes.
Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast
Before:
After: