Components: Fix UnitControl disabled style is overridden by WP forms.css#45250
Merged
Components: Fix UnitControl disabled style is overridden by WP forms.css#45250
UnitControl disabled style is overridden by WP forms.css#45250Conversation
t-hamano
changed the title
UnitControl disabled style is overridden by common styleUnitControl disabled style is overridden by core form style
t-hamano
changed the title
UnitControl disabled style is overridden by core form styleUnitControl disabled style is overridden by WP forms.css
aristath
force-pushed
the
fix/unit-control-core-override
branch
from
401cf34 to
ef554e1
Compare
t-hamano
force-pushed
the
fix/unit-control-core-override
branch
from
ef554e1 to
f2bf3f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes a problem where the
disabledstyle ofUnitControlis overridden by the style in the coreforms.css.Why?
As shown in the screencast below, WordPress admin style is applied by the priority of CSS specificity.
dd8e35a7fb9108118785707a4c0844c1.mp4
How?
Changed
&&to&&&for one more CSS specificity in the component.Testing Instructions
disabledproperty ofUnitControltotrue.Note: The font family will change, but this is a matter of inheritance and expected behavior.