Adds a modal version of the block inserter only in Distraction Free mode#44932
Closed
draganescu wants to merge 2 commits intotrunkfrom
Closed
Adds a modal version of the block inserter only in Distraction Free mode#44932draganescu wants to merge 2 commits intotrunkfrom
draganescu wants to merge 2 commits intotrunkfrom
Conversation
|
Size Change: +280 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
mtias
added
the
[Feature] Inserter
Contributor
Author
|
On refactoring:
|
draganescu
force-pushed
the
try/modal-inserter
branch
from
b367b71 to
eaccab4
Compare
Contributor
|
Hi @draganescu - I am a total fan of the distraction-free mode and I tested this inserter modal. Here are my first thoughts. I am a bit concerned to have the same UI asset (blue button with the cross) do different things depending on the active mode. I also have a hunch that a person being intrigued by Distraction-free mode would also prefer keyboard navigation, so they don't need to change controls (Mouse/trackpad to keyboard and back) . Using the Inserter from the Top Toolbar using-blue-inserter-distraction-free.mp4Using the Slash command. If I use the Slash command, I get there much, much faster
This is the video for using the slash command. Maybe the inserter should not be available via the Distraction-free mode at all? I would love to see a little Welcome Guide that would explain
I would even be as radical, and remove placeholder text for the new paragraph "Type / to choose a block". |
Member
|
I think this approach works — it keeps the editing experience tailored for publishing instead of invoking the whole block inserter. Probably as a follow-up, but I wonder if we should surface blocks related to writing (purposely ignoring the paragraph block) such as:
|
Member
|
Thinking about this more: is this a necessary addition to Distraction Free mode? I'm leaning towards not. We have the empty block inserter, and the backslash hint for empty paragraph blocks. I don't think we need to introduce another method for inserting blocks.
I'd say focusing on the top toolbar improvements will yield a better experience. |
Contributor
Author
|
I think @mtias had a strong opinion about having the inserter available. In the meantime I'll rebase this. |
Member
|
We could use the command palette (#48457) for inserting blocks when that's coming together. Adding blocks could certainly be a use case within that experience. |
richtabor
changed the title
Contributor
Author
|
Yes I had the same thinking line, I even thought this modal inserter could be the start of that command palette. |
Member
We do have this early POC for the command palette: #49152 |
Contributor
Author
|
Top toolbar is improved but alas still incompatible with distraction free mode (because it still has to be rendered close to the block in the dom). |
Contributor
Author
|
I will close this for the idea to insert blocks from the command palette. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Continues the work in #41740.
Why?
To have a version of the inserter specific to distraction free mode. It was one of the remaining items in the original PR:
How?
Adds a modified version of the quick inserter into a modal.
Testing Instructions
Screenshots or screencast
modal-inserter-no-focus.mp4
To do
access + I)