[Block Library - Quote]: Restrict single block transforms to specific blocks#44106
Merged
ntsekouras merged 1 commit intotrunkfrom Sep 13, 2022
Merged
Conversation
ntsekouras
added
[Package] Block library
Contributor
|
Thanks for the PR! Can you provide some demo content or a video, I'm not quite sure I see any difference between trunk and this PR:
|
|
Size Change: +41 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
Contributor
Author
I updated the description with some videos. |
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow up of: #44072
When the Quote block updated to support inner blocks it enabled a wildcard transformation for every block, similar to the
Groupblock. For most single blocks though doesn't make sense to be offered as an option.This PR makes the option available to only a handful blocks(
core/paragraph, core/heading, core/list, core/pullquote, when a single block is selected. If any multiple blocks are selected the option is preserved.Testing Instructions
Before
Screen.Recording.2022-09-13.at.10.45.50.AM.mov
After
Screen.Recording.2022-09-13.at.10.44.02.AM.mov